** Description changed:
[Impact]
- json hooks ending with EPIPE on first read fail, but should simply do
nothing.This causes spurious failures of uninstalled hooks.
+ json hooks ending with EPIPE on first read fail, but should simply do
nothing. This causes spurious failures of uninstalled hooks.
+
+ Also, there is a missing error exit, causing errors reported by the
+ script to not exit.
[Test case]
- Cannot generate one. This was discovered by snapd ci, but I did not find a
reproducer yet.
+ For the first part, I cannot generate one. This was discovered by snapd ci,
but I did not find a reproducer yet.
FWIW, the change should be tiny enough to see that it is not wrong:
- if (errno != ECONNRESET)
+ if (errno != ECONNRESET && errno != EPIPE)
- _error->Error("Could not read response to hello message from hook
%s: %s", Opts->Value.c_str(), strerror(errno));
+ _error->Error("Could not read response to hello message from hook
%s: %s", Opts->Value.c_str(), strerror(errno));
+
+ The missing error handling is the next lines:
+ else if (strstr(line, "error") != nullptr)
+ {
+ _error->Error("Hook %s reported an error during hello: %s",
Opts->Value.c_str(), line);
+ + goto out;
+ }
+
+
+ that can be checked:
+
+ sudo apt -o AptCli::Hooks::Install::="/usr/bin/printf '{error should be
+ json}\n\n' >&3" install
[Regression potential]
JSON hooks failures with EPIPE are now ignored, so if it fails with EPIPE for
other reasons than just exiting, I guess we might miss it
** Also affects: apt (Ubuntu Bionic)
Importance: Undecided
Status: New
** Also affects: apt (Ubuntu Disco)
Importance: Undecided
Status: Fix Released
** Also affects: apt (Ubuntu Cosmic)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1814543
Title:
deal with EPIPE from json hooks
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1814543/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
