Meh, I'd rather see /usr/lib/libvirt/libvirt-guests.sh at the end of
stop, iterate across `virsh net-list` and call `virsh net-destroy` on
them.

However, this is too heavy weight for shutdown. As net-destroy does much
more than just killing dnsmasq. It appears to remove the bridge & nics
too (which in turn triggers netwokrd/networkd-dispatcher/udevd churn).

Ideally, I only want to kill the dnsmasq processes somehow.

I don't like #2 approach at all. It seems like introducing simple
template units [email protected] is better, with net-name as the
instance name. And make them be part of the libvirtd cgroup, although
not required. Because we want these to be shutdown normally, and it
shouldn't be needed to e.g. destroy/recreate network interface, just to
restart dnsmasq for a libvirt network. And libvirt should be using
systemctl (on systemd booted machines) to start/stop libvirt-
[email protected] instances imho. But also i guess, much larger code
change, as libvirtd now need to learn to call systemctl to
start/stop/restart units, rather than fork/exec dnsmasq.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1818711

Title:
  never kills dnsmasq servers

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1818711/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to