Coders usually think "scripts/APIs first, manual edit maybe later"
therefore I haven't thought of the snapshot-edit yet.

The 'Failed. Try again? [y,n,f,?]:' seems to be on the other end of the world 
(code-wise).
That is in vshAskReedit of tools/vsh.c

It comes together with snapshots around cmdSnapshotEdit of 
tools/virsh-snapshot.c
There it uses the defines for tools/virsh-edit.c and the path important for us 
here should be EDIT_DEFINE.

The latter calls "virDomainSnapshotCreateXML"

With that in place I have created a new test build in [1].
If I try to change e.g. machine type without by using snapshot-edit I get as 
expected:

error: unsupported configuration: Target domain machine type pc-i440fx-bionic 
does not match source pc-i440fx-disco                                           
                                                                                
                                  
Failed. Try again? [y,n,f,?]:      

With the further fix the interactive edit has now an "i" option which is
meant for "ignore validation".

Example:

$ virsh snapshot-edit disco-checksnapshot 1551877228
error: unsupported configuration: Target domain machine type pc-i440fx-bionic 
does not match source pc-i440fx-disco
Failed. Try again? [y,n,i,f,?]: i
Snapshot 1551877228 edited.

And it worked saving and using it juts fine.

@Richud - would that be what you need?

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3651

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1802944

Title:
  error: unsupported configuration: Target domain machine type

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1802944/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to