** Description changed: [Impact] - * The kernel can't find /dev/root when booting initramfsless thus can't resume from hibernation - * The fix sets resume=... to the same identifier passed as root=... on the kernel command line when the swap file is found on the root partition. + * The kernel can't find /dev/root when booting initramfsless thus can't resume from hibernation + * The fix sets resume=... to the same identifier passed as root=... on the kernel command when the swap file is found to be on /dev/root. [Test Case] - * (Install and) start hibinit-agent on an EC2 instance supporting hibernation, then when it started successfully verify the grub configuration: - $ grep -m 1 root= /boot/grub/grub.cfg - linux /boot/vmlinuz-4.18.0-1008-aws root=PARTUUID=6b4ea835-01 ro console=tty1 console=ttyS0 nvme.io_timeout=4294967295 no_console_suspend=1 resume_offset=438272 resume=PARTUUID=6b4ea835-01 + * (Install and) start hibinit-agent on an EC2 instance supporting hibernation, then when it started successfully verify the grub configuration: + $ grep -m 1 root= /boot/grub/grub.cfg + linux /boot/vmlinuz-4.18.0-1008-aws root=PARTUUID=6b4ea835-01 ro console=tty1 console=ttyS0 nvme.io_timeout=4294967295 no_console_suspend=1 resume_offset=438272 resume=PARTUUID=6b4ea835-01 - resume=... must match root=... with the default configuration. + resume=... must not refer to /dev/root with the default configuration, + but to a block device known to the kernel without using initramfs. [Regression Potential] - * Hibinit-agent may parse the grub configuration file incorrectly and + * Hibinit-agent may parse the grub configuration file incorrectly and set a wrong partition to resume from. Since the fix is quite small and the number of variants of grub configurations is also small this regression is unlikely.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1818150 Title: Hibinit-agent configures GRUB referring to root partition as resume=/dev/root To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1818150/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
