Public bug reported:

In curtin/block/zfs.py the definition of zpool_create is

def zpool_create(poolname, vdevs, mountpoint=None, altroot=None,
                 pool_properties=None, zfs_properties=None):

But this method is called from curtin/commands/block_meta.py without the
pool_properties and zfs_properties:

    zfs.zpool_create(poolname, vdevs_byid,
                     mountpoint=mountpoint, altroot=altroot)

So the properties defined in the configuration file are never applied to
the pool.

Besides the documentation specifies that zfs filesystem properties are
set with fs_properties while in the code it's called zfs_properties.
It'd be more consistent to name them identically

ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: curtin (not installed)
ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1
Uname: Linux 5.0.0-8-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.10-0ubuntu25
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon Apr  8 11:38:50 2019
InstallationDate: Installed on 2014-07-15 (1728 days ago)
InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
SourcePackage: curtin
UpgradeStatus: Upgraded to disco on 2018-03-24 (379 days ago)

** Affects: curtin (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: amd64 apport-bug disco

** Description changed:

  In curtin/block/zfs.py the definition of zpool_create is
  
  def zpool_create(poolname, vdevs, mountpoint=None, altroot=None,
-                  pool_properties=None, zfs_properties=None):
+                  pool_properties=None, zfs_properties=None):
  
  But this method is called from curtin/commands/block_meta.py without the
  pool_properties and zfs_properties:
  
-     zfs.zpool_create(poolname, vdevs_byid,
-                      mountpoint=mountpoint, altroot=altroot)
+     zfs.zpool_create(poolname, vdevs_byid,
+                      mountpoint=mountpoint, altroot=altroot)
  
  So the properties defined in the configuration file are never applied to
  the pool.
  
- Besides the documentation specified that zfs filesystem properties are
+ Besides the documentation specifies that zfs filesystem properties are
  set with fs_properties while in the code it's called zfs_properties.
  It'd be more consistent to name them identically
  
  ProblemType: Bug
  DistroRelease: Ubuntu 19.04
  Package: curtin (not installed)
  ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1
  Uname: Linux 5.0.0-8-generic x86_64
  NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
  ApportVersion: 2.20.10-0ubuntu25
  Architecture: amd64
  CurrentDesktop: ubuntu:GNOME
  Date: Mon Apr  8 11:38:50 2019
  InstallationDate: Installed on 2014-07-15 (1728 days ago)
  InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
  SourcePackage: curtin
  UpgradeStatus: Upgraded to disco on 2018-03-24 (379 days ago)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1823682

Title:
  zfs pool and fs properties are not passed to zfs.zpool_create

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/curtin/+bug/1823682/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to