I'm talking about user properties not native properties.
User properties are arbitrary properties which name contains a ':' and
values are arbitrary strings which are never validated. It can be used
to annotate datasets. (See user properties in zfs man for more details)
Current behavior of curtin makes the wrong assumption for user
properties that they can be typed and convert the values of boolean
values while it should be treated as strings and left untouched.
** Changed in: curtin (Ubuntu)
Status: Incomplete => Triaged
** Description changed:
In zfs.py there is this code:
- 49 # zfs flags and params require string booleans ('on', 'off')
- 50 # yaml implicity converts those and others to booleans, we
- 51 # revert that here
- 52 def _b2s(value):
- 53 if not isinstance(value, bool):
- 54 return value
- 55 if value:
- 56 return 'on'
- 57 return 'off'
- 58
- 59 return [] if not params else (
- 60 [param for opt in zip([optflag] * len(params),
- 61 ["%s=%s" % (k, _b2s(v))
- 62 for (k, v) in params.items()])
+ 49 # zfs flags and params require string booleans ('on', 'off')
+ 50 # yaml implicity converts those and others to booleans, we
+ 51 # revert that here
+ 52 def _b2s(value):
+ 53 if not isinstance(value, bool):
+ 54 return value
+ 55 if value:
+ 56 return 'on'
+ 57 return 'off'
+ 58
+ 59 return [] if not params else (
+ 60 [param for opt in zip([optflag] * len(params),
+ 61 ["%s=%s" % (k, _b2s(v))
+ 62 for (k, v) in params.items()])
- It has the consequence to force any boolean value that seems to on/off.
- For user properties the value may look like a boolean but could be anything
for example yes/no/maybe.
+ It has the consequence to force any value that seems to be a boolean to
on/off.
+ For user properties the value may look like a boolean but it is an arbitrary
string and can be anything for example yes/no/maybe.
Curtin must not assume a type and a value for user properties and set
the value as it is defined in the yaml configuration file.
ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: curtin (not installed)
ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1
Uname: Linux 5.0.0-8-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.10-0ubuntu26
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Wed Apr 10 17:02:09 2019
InstallationDate: Installed on 2014-07-15 (1730 days ago)
InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
SourcePackage: curtin
UpgradeStatus: Upgraded to disco on 2018-03-24 (382 days ago)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1824172
Title:
Do not force value of user properties to on/off
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/curtin/+bug/1824172/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
