Thanks for the review. * I rewrite the copyright file, it should me more simple and better. * Man pages have been fix, there is no options in the command line, so it's pretty simple. * control fix. I hope the description is enought. * rules fix.
The update package is available in REVU : http://revu.tauware.de/details.py?package=avant-window-navigator Le vendredi 16 novembre 2007 à 13:25 +0000, Sebastien Bacher a écrit : > Thank you for your work on that. I looked at the package on REVU, some > comments > > * avant-window-navigator.1 > > not sure that the fact that the application is written in C is of any > interest in a manpage > > * awn-applet-activation.1 > > you use "awn-applet-activation", "Awn-applet-activation", "wwn-applet- > activation", consistency would be nice there > > * awn-manager.1 > > The synopsys formatting looks incorrect > > * control: > > libawn-dev should Depends on libawn0 (= ${binary:Version}) > the library description could be improved > awn-manager should be arch all > > * copyright > > you mention that the code is underl GPL2 only where the source files state > it's GPL2 or any new version > you list awn-applet-*.* using the LGPL, src/awn-applet-* are under the GPL > though and eggtraymanager which is not distributed in the source > you wrote " License (everything not mentioned below)" and list copyright > holders which is slightly weird > > * rules > > you should "+=" for assignement to add arguments to the one which might > be already used > > * The manpages synopsis are not meant to be a copy of the description > but a summary of the command name and options it can use > > > The copyright issues have to be fixed before the package can be uploaded > -- [needs-packaging] Avant Window Navigator https://bugs.launchpad.net/bugs/118589 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
