Thank you for driving these SRUs! A couple of minor comments that I
didn't think it was worth blocking on:

I'd prefer ubuntu0.1 over ubuntu1 for SRUs. There isn't a hard policy on
this, but it does make it clear that it's an SRU just from the version
number, reduces the need to check for collisions (there can be none this
time though) to only coincident version numbers across releases, and
matches the recommendation linked from the SRU wiki page.

On the changelog entry, for SRUs specifically, I think it would be
helpful to illustrate why a user would want to take the update, rather
than just what is being changed, because apparently some users do read
the changelogs. So I'd have added something about how this fixes the
package when used in a container.

I didn't think that was enough reason to block you though, as this has
been in the sponsorship queue long enough, so I uploaded.

Now awaiting SRU team review (which I can't do because I sponsored).

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1820144

Title:
  iptables-persistent fails in containers due to modprobe being
  unavailable even though module could've been loaded outside of the
  container

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iptables-persistent/+bug/1820144/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to