** Description changed:

+ [Impact]
+ 
+ The dkms version available in disco regressed in behavior in comparison
+ to earlier series, causing `dkms uninstall` removing the module from the
+ built tree instead of only uninstalling it. Per the dkms manpage, an
+ uninstall operation should leave the module in the 'built' state, while
+ currently it ends up only in the 'added' state.
+ 
+ This breaks our current shim-signed logic, since on postinst we're
+ uninstalling every dkms module, checking if we uninstalled it correctly
+ by making sure it's in the 'built' state and then signing it if
+ everything is ok. And this is now broken.
+ 
+ This seemed to have been introduced unintentionally as the manpage still 
notes for `dkms uninstall`:
+ "Uninstalls an installed module/module-version combo from the kernel/arch 
passed in the -k option, or the current kernel if the -k option was not passed 
upon. After uninstall completion, the driver will be left in the built state.
+ To completely remove a driver, the remove action should be utilized."
+ 
+ The bug has been made visible with the bcmwl-kernel-source driver,
+ which, if installed before shim-signed, will then become uninstalled and
+ not reinstalled again (because of the failed status check before
+ signing).
+ 
+ [Test Case]
+ 
+ An easy way of checking if the uninstall logic has been reverted:
+ 
+  1. On a disco system, install the dkms and bcmwl-kernel-source packages 
(-proposed disabled).
+  2. Check the version of the module installed `dkms status`.
+  3. Once the installation completes, uninstall the bcmwl dkms module from the 
system:
+  `dkms uninstall bcmwl/<VERSION>`
+  4. Checks that the status is not reported as 'built' (should be something 
like 'added' only):
+  `dkms status bcmwl`
+  5. Enable disco-proposed and upgrade dkms.
+  6. Re-install the bcmwl-kernel-source package.
+  7. Once again uninstall the bcmwl dkms module:
+  `dkms uninstall bcmwl/<VERSION>`
+  8. Check the status and notice that it is now reported as 'built':
+  `dkms status bcmwl`
+ 
+ Another way would be checking on a secureboot-enabled system that has
+ Broadcom wireless installing the -proposed dkms, then bcmwl-kernel-
+ source and finally shim-signed (reinstalling if necessary). This
+ operation should result in the broadcom dkms module still being
+ installed and active. But this test should be counted as an optional
+ 'additional test'.
+ 
+ [Regression Potential]
+ 
+ Since this does change the dkms uninstall behavior, there is always some
+ risk involved. One of the potential regressions could be related to
+ kernel uninstallation, as we are reverting parts of the kernel prerm
+ scripts along with the revert - but the risk should be low as we're
+ actually reverting to the state we had in all series prior to disco. In
+ overall the uninstall command of dkms might have regressed its behavior
+ in case some other place started assuming the removals of modules from
+ the built directory, but seeing the disco diff it's highly improbable.
+ 
+ [Original Description]
+ 
  For 19.04 UB did a minimal install.  I selected the ubiquity proprietary
  option and expected the broadcom driver to be found and installed.
  
  On reboot I could not see any wireless networks.  I went to the
  Additional Drivers window and it stated that the computer was indeed
  using Broadcom 802.11 Linux STA wireless driver and was in use.
  
  This is a regression - in both 18.04 and 18.10, the same steps also
  installed the driver, and wireless networks were found and could be
  connected to.
  
  ProblemType: BugDistroRelease: Ubuntu 19.04
  Package: linux-image-5.0.0-7-generic 5.0.0-7.8
  ProcVersionSignature: Ubuntu 5.0.0-7.8-generic 5.0.0
  Uname: Linux 5.0.0-7-generic x86_64
  ApportVersion: 2.20.10-0ubuntu23
  Architecture: amd64
  AudioDevicesInUse:
   USER        PID ACCESS COMMAND
   /dev/snd/controlC0:  dad        1060 F.... pulseaudio
  CurrentDesktop: Budgie:GNOME
  Date: Wed Mar 27 00:25:09 2019
  InstallationDate: Installed on 2019-03-27 (0 days ago)
  InstallationMedia: Ubuntu-Budgie 19.04 "Disco Dingo" - Alpha amd64 
(20190326.1)
  IwConfig:
   lo        no wireless extensions.
  
   enp3s0    no wireless extensions.
  Lsusb:
   Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
   Bus 001 Device 004: ID 0a5c:216d Broadcom Corp. BCM43142A0 Bluetooth 4.0
   Bus 001 Device 003: ID 05c8:022a Cheng Uei Precision Industry Co., Ltd 
(Foxlink)
   Bus 001 Device 002: ID 05e3:0608 Genesys Logic, Inc. Hub
   Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
  MachineType: HP HP Notebook
  ProcFB: 0 EFI VGA
  ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.0.0-7-generic 
root=UUID=25581458-0e76-468f-8318-628c1a279716 ro nomodeset quiet splash
  RelatedPackageVersions:
   linux-restricted-modules-5.0.0-7-generic N/A
   linux-backports-modules-5.0.0-7-generic  N/A
   linux-firmware                           1.178
  RfKill:
   0: hci0: Bluetooth
    Soft blocked: no
    Hard blocked: noSourcePackage: linux
  UpgradeStatus: No upgrade log present (probably fresh install)
  WifiSyslog:
  
  dmi.bios.date: 02/15/2016
  dmi.bios.vendor: Insyde
  dmi.bios.version: F.1F
  dmi.board.asset.tag: Type2 - Board Asset Tag
  dmi.board.name: 80BF
  dmi.board.vendor: HP
  dmi.board.version: 95.16
  dmi.chassis.asset.tag: Chassis Asset Tag
  dmi.chassis.type: 10
  dmi.chassis.vendor: HP
  dmi.chassis.version: Chassis Version
  dmi.modalias: 
dmi:bvnInsyde:bvrF.1F:bd02/15/2016:svnHP:pnHPNotebook:pvr:rvnHP:rn80BF:rvr95.16:cvnHP:ct10:cvrChassisVersion:
  dmi.product.family: 103C_5335KV G=N L=CON B=HP
  dmi.product.name: HP Notebook
  dmi.product.sku: N9S73EA#ABU
  dmi.sys.vendor: HP

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1821823

Title:
  No wireless networks displayed for broadcom BCM43142

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dkms/+bug/1821823/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to