Why didn't the compiler warn about the uninitialized variable? Don't you use -Wuninitialized (or -Wall for developing)?
My first corrected patch is still not checking the return value of g_spawn_command_line_sync(). https://developer.gnome.org/glib/stable/glib-Spawning-Processes.html#g-spawn-command-line-sync Fixed this now. Again, I don't have the source checked out, so I _manually_ edited the patch. It may not apply cleanly. Note for the upstream bug[1], that this function has changed in master. It now calls https://git.xfce.org/xfce/xfce4-session/tree/xfce4-session/xfce-screensaver.c#n484. That function still has that bug in the SCREENSAVER_TYPE_OTHER case. The fix should look similar to what I attached. I might write a patch in a few weeks if you don't beat me to it. :) [1]: https://bugzilla.xfce.org/show_bug.cgi?id=10089 ** Patch added: "check return value of g_spawn_command_line_sync()" https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1054299/+attachment/5258042/+files/xfsm-systemd.c.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1054299 Title: Race condition in suspend scripts reveals desktop To manage notifications about this bug go to: https://bugs.launchpad.net/unity/+bug/1054299/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
