Public bug reported: We have a warning[1] in dmesg shows hns register napi as weight 256 but not recommended. According to this commit[2] we shall use weight 64 as suggested.
To cherry-pick this makes hns driver has reasonable weight commit acb1ce15a61154aa501891d67ebf79bc9ea26818 Author: Yonglong Liu <[email protected]> Date: Thu Apr 4 16:46:43 2019 +0800 net: hns: Use NAPI_POLL_WEIGHT for hns driver When the HNS driver loaded, always have an error print: "netif_napi_add() called with weight 256" This is because the kernel checks the NAPI polling weights requested by drivers and it prints an error message if a driver requests a weight bigger than 64. So use NAPI_POLL_WEIGHT to fix it. Signed-off-by: Yonglong Liu <[email protected]> Signed-off-by: Peng Li <[email protected]> Signed-off-by: David S. Miller <[email protected]> [1] netif_napi_add() called with weight 256 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82dc3c63c692b1e1d59378ecee948ac88e034aad ** Affects: linux (Ubuntu) Importance: Undecided Assignee: Ike Panhc (ikepanhc) Status: Incomplete ** Affects: linux (Ubuntu Bionic) Importance: Undecided Assignee: Ike Panhc (ikepanhc) Status: Incomplete ** Affects: linux (Ubuntu Cosmic) Importance: Undecided Assignee: Ike Panhc (ikepanhc) Status: Incomplete ** Affects: linux (Ubuntu Disco) Importance: Undecided Assignee: Ike Panhc (ikepanhc) Status: Incomplete ** Affects: linux (Ubuntu Eoan) Importance: Undecided Assignee: Ike Panhc (ikepanhc) Status: Incomplete ** Also affects: linux (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Eoan) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Disco) Importance: Undecided Status: New ** Changed in: linux (Ubuntu Eoan) Assignee: (unassigned) => Ike Panhc (ikepanhc) ** Changed in: linux (Ubuntu Disco) Assignee: (unassigned) => Ike Panhc (ikepanhc) ** Changed in: linux (Ubuntu Cosmic) Assignee: (unassigned) => Ike Panhc (ikepanhc) ** Changed in: linux (Ubuntu Bionic) Assignee: (unassigned) => Ike Panhc (ikepanhc) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830587 Title: Reduce NAPI weight in hns driver from 256 to 64 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1830587/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
