> Failing to remove the module, means the testcase / systemd has failed.
well, not if the module is built-in > Whilst the proposed improvements to the test case are ok, they make it skip a lot more isn't the entire test currently skipped if the module is already loaded? ;) but i get your point, it skips the test if 1) scsi_debug isn't available, 2) scsi_debug add_host interface doesn't work right, 3) scsi_debug adapter* subdir count is != 1 (instead of previously, failing the test) I don't think any of those should cause a test failure, but if you think they should they can change from skiptest to assert. > And upon starting the test case we do need to re-insert the module, > as otherwise LUKS2 header creation would fail (that affects disco+ only). why will it fail without module re-insertion? It doesn't in my test runs. > I do like the add_host usage, but I wonder if it's best be used with udevadm > settle calls, rather than manual tight loops. I don't think the add_host loops are needed at all; I only added them because there's existing (infinite) loop waiting for the glob to match. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829347 Title: systemd autopkgtest 'storage' fails adding/rmmoding scsi_debug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1829347/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
