Hi Alvin, Good progress! And thanks for documenting the patch. I would suggest a few changes:
* Instead of calling it 'mypatch.diff' give it a descriptive name, like 'fix-version-string.patch' * In the patch metadata, make sure to replace all the stuff in <angle brackets>. For example, instead of: Description: Replace %%VSN%% in rabbitmqadmin with version number <long description that can span multiple lines, optional> Author: Alvin Joseph Tang, alvint...@gmail.com Origin: <upstream|backport|vendor|other>, <URL, required except if Author is present> Bug: https://bugs.launchpad.net/ubuntu/+source/rabbitmq-server/+bug/1773324 Applied-Upstream: <version|URL|commit, identifies patches merged upstream, optional> Reviewed-by: <name and email of a reviewer, optional> Last-Update: You could say something like: Description: Replace %%VSN%% in rabbitmqadmin with version number Author: Alvin Joseph Tang, alvint...@gmail.com Origin: backport Bug: https://bugs.launchpad.net/ubuntu/+source/rabbitmq-server/+bug/1773324 Applied-Upstream: 3.6.10 Reviewed-by: Bryce Harrington <br...@canonical.com> Last-Update: 2019-06-05 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1773324 Title: rabbitmqadmin shows %%VSN%% as version To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/rabbitmq-server/+bug/1773324/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
