** Description changed:
+ [Impact]
+
+ * During Bionic's OpenJDK 11 transition the tomcat8 package was updated
+ to the newest version. As the update was done in bionic-security there
+ were concerns with updating conffiles, which could cause the package to
+ now be updated by unattended-upgrades. Thus any such changes were rolled
+ back to keep conffiles the same. Unfortunately one script
+ (debian/tomcat8-instance-create) was not properly rolled back. This
+ causes the script to fail to update the server.xml configuration when
+ creating a new instance, making it a bit useless.
+
+ [Test Case]
+
+ 1. Install tomcat8
+ $ apt install tomcat8
+ 2. Create a new instance
+ $ tomcat8-instance-create -p 8888 -c 9999 instance-name
+ 3. Verify that conf/server.xml has been updated with the right connector (-p
argument) and control ports (-c argument)
+
+ In the non-patched tomcat8, in step #3, the connector and control ports
+ won't be changed and will still be set to the default setting (8080 and
+ 8005).
+
+ [Regression Potential]
+
+ * Since this effectively introduces a required rollback so the tomcat8
+ -instance-create can work on the default server.xml conffile no
+ regressions are expected.
+
+ [Original Description]
The parameter -c (controlport) is not used anymore. I tried
tomcat8-instance-create -c 9999 -p 8888 instance-name
In conf/server.xml the controlport still set to 8005 (default) value.
-
The reason is located in line 120 of tomcat8-instance-create.
-
There is:
sed -i -e "s/Connector port=\"8080\"/Connector
port=\"${HPORT}\"/;s/Server port=\"-1\" shutdown=\"SHUTDOWN\"/Server
port=\"${CPORT}\" shutdown=\"${CWORD}\"/" "${TARGET}/conf/server.xml"
...and there should be:
sed -i -e "s/Connector port=\"8080\"/Connector
port=\"${HPORT}\"/;s/Server port=\"8005\" shutdown=\"SHUTDOWN\"/Server
port=\"${CPORT}\" shutdown=\"${CWORD}\"/" "${TARGET}/conf/server.xml"
-
Thanks a lot and have a nice weekend!
Stefan.
** Summary changed:
- "-1" instead of "8005" in tomcat8-instance-create
+ [SRU] tomcat8-instance-create fails to update connector and control ports
** Tags added: bionic
** Description changed:
[Impact]
- * During Bionic's OpenJDK 11 transition the tomcat8 package was updated
- to the newest version. As the update was done in bionic-security there
- were concerns with updating conffiles, which could cause the package to
- now be updated by unattended-upgrades. Thus any such changes were rolled
- back to keep conffiles the same. Unfortunately one script
- (debian/tomcat8-instance-create) was not properly rolled back. This
- causes the script to fail to update the server.xml configuration when
- creating a new instance, making it a bit useless.
+ * During Bionic's OpenJDK 11 transition the tomcat8 package was updated to
the newest version. As the update was done in bionic-security there were
concerns with updating conffiles, which could cause the package to now be
updated by unattended-upgrades. Thus any such changes were rolled back to keep
conffiles the same. Unfortunately one script (debian/tomcat8-instance-create)
was not properly rolled back. This causes the script to fail to update the
server.xml configuration when creating a new instance, making it a bit useless.
+ * Since only Bionic's tomcat8 had the conffiles rolled back, no other
release has been affected - ie. Cosmic and later releases shipped with a
tomcat8 that already included the conffile changes.
[Test Case]
1. Install tomcat8
- $ apt install tomcat8
+ $ apt install tomcat8
2. Create a new instance
- $ tomcat8-instance-create -p 8888 -c 9999 instance-name
+ $ tomcat8-instance-create -p 8888 -c 9999 instance-name
3. Verify that conf/server.xml has been updated with the right connector (-p
argument) and control ports (-c argument)
In the non-patched tomcat8, in step #3, the connector and control ports
won't be changed and will still be set to the default setting (8080 and
8005).
[Regression Potential]
- * Since this effectively introduces a required rollback so the tomcat8
+ * Since this effectively introduces a required rollback so the tomcat8
-instance-create can work on the default server.xml conffile no
regressions are expected.
+
+ [Other Info]
+
+ * Affects only Bionic (see Impact for details).
+
[Original Description]
The parameter -c (controlport) is not used anymore. I tried
tomcat8-instance-create -c 9999 -p 8888 instance-name
In conf/server.xml the controlport still set to 8005 (default) value.
The reason is located in line 120 of tomcat8-instance-create.
There is:
sed -i -e "s/Connector port=\"8080\"/Connector
port=\"${HPORT}\"/;s/Server port=\"-1\" shutdown=\"SHUTDOWN\"/Server
port=\"${CPORT}\" shutdown=\"${CWORD}\"/" "${TARGET}/conf/server.xml"
...and there should be:
sed -i -e "s/Connector port=\"8080\"/Connector
port=\"${HPORT}\"/;s/Server port=\"8005\" shutdown=\"SHUTDOWN\"/Server
port=\"${CPORT}\" shutdown=\"${CWORD}\"/" "${TARGET}/conf/server.xml"
Thanks a lot and have a nice weekend!
Stefan.
** Changed in: tomcat8 (Ubuntu)
Importance: Undecided => High
** Changed in: tomcat8 (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1827090
Title:
[SRU] tomcat8-instance-create fails to update connector and control
ports
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/tomcat8/+bug/1827090/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
