Attaching debdiff to this comment for SRU consideration into Bionic. Adding SRU information to original bug description.
Thank you for the patch, Trent! ** Patch added: "virtualbox_5.2.18-dfsg-2~ubuntu18.04.6.debdiff" https://bugs.launchpad.net/ubuntu/+source/virtualbox/+bug/1829248/+attachment/5275300/+files/virtualbox_5.2.18-dfsg-2~ubuntu18.04.6.debdiff ** Description changed: + [Impact] + + * virtualbox-dkms fails to build on 5.0 kernels. This affects Bionic + because the Bionic HWE Edge kernels are based on 5.0. virtualbox-dkms + cannot be installed successfully since the DKMS module can't be compiled + due to API changes introduced between Linux 4.15 and 5.0. + + [Test Case] + + * Install the HWE Edge kernel on Bionic: + - `sudo apt install linux-generic-hwe-18.04-edge` + * Reboot into the new kernel (you should be on a 5.0 kernel now) + * Try installing `virtualbox-dkms` (`sudo apt install virtualbox-dkms`) + - Expected result: package installs successfully, module can be viewed with `sudo dkms status` + - Actual result: Installation fails due to compilation errors when building the DKMS module. + + [Testing] + + These steps were performed in an amd64 virtual machine installed from a + Bionic cloud image for both the 4.15 kernel that comes with the image as + well as a 5.0.0 kernel that is installed from the HWE Edge package. + + * Create a .deb with the .debdiff attached to comment #3 + - `sudo apt build-dep virtualbox` (you will need to uncomment the deb-src lines in /etc/apt/sources.list if you haven't already) + - `pull-lp-source virtualbox bionic` + - `patch -p1 < path/to/patch.debdiff` + - `quilt push -a` + - `debuild -b -us -uc` + == the step above can be completed just once independently of which kernel you're testing on == + + * Install `virtualbox-dkms` with apt and confirm it installs properly (only on 4.15; on 5.0, this step should fail) + - `sudo apt install virtualbox-dkms` + * Remove `virtualbox-dkms` + - `sudo apt remove virtualbox-dkms` + * Install the new .deb prepared in the first step. + * Confirm that installation succeeded (there would be errors if it didn't.) The module should also be listed when running `sudo dkms status` -- this step should succeed on both 4.15 and 5.0 kernels. + + [Regression Potential] + + * These changes are conditionally compiled depending on the kernel + version. The only exception to this is the addition of an inlined + function for operating on timespec64. That is conditionally compiled + based on whether the kernel has timespec64, not necessarily just on the + kernel version. + + + Original bug description follows: + ---------------------------------- + v5.2.18 dkms fails to build on bionic with the recently released 5.0 kernel from hwe-18.04-edge I've attached a patch which doesn't seem to not work. It should definitely be reviewed by someone with domain knowledge, though. The problems were all use of interfaces deprecated in 4.0. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829248 Title: v5.2.18 dkms fails to build with 5.0 kernel on bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/virtualbox/+bug/1829248/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
