** Description changed:
- https://launchpadlibrarian.net/417924491/buildlog_ubuntu-disco-
- amd64.xen_4.9.2-0ubuntu2_BUILDING.txt.gz
+ [Impact]
+ Warning message causes FTBFS when configured to treat warnings as errors.
- gcc -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable
-Wno-unused-local-typedefs -O2 -fomit-frame-pointer
-D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
.xen-lowmemd.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Werror -include
/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/config.h
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libs/evtchn/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libxc/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libs/toollog/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libs/foreignmemory/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libs/devicemodel/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-D__XEN_TOOLS__
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/xenstore/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-c -o xen-lowmemd.o xen-lowmemd.c
- xen-lowmemd.c: In function ‘handle_low_mem’:
- xen-lowmemd.c:80:55: error: ‘%s’ directive output may be truncated writing up
to 511 bytes into a region of size 489 [-Werror=format-truncation=]
- snprintf(error, BUFSZ,"Failed to write target %s to xenstore", data);
- ^~ ~~~~
- In file included from /usr/include/stdio.h:867,
- from xen-lowmemd.c:6:
+ [Test Case]
+ $ apt-get source xen
+ (...)
+ $ cd xen*
+ $ sudo apt-get build-dep xen
+ (...)
+ $ ./configure
+ (...)
+ $ make
+ (...)
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note:
‘__builtin___snprintf_chk’ output between 36 and 547 bytes into a destination
of size 512
- return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
+ return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
__bos (__s), __fmt, __va_arg_pack ());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ cc1: all warnings being treated as errors
+ make[4]: *** [/home/ubuntu/xen-4.9.2/tools/misc/../../tools/Rules.mk:220:
xen-lowmemd.o] Error 1
+ make[4]: Leaving directory '/home/ubuntu/xen-4.9.2/tools/misc'
+ $ echo $?
+ 2
+
+ [Regression Potential]
+ Changes string formatting of an error message, which should be
+ transparent to users, but things to watch for would relate to xen's
+ error message logs.
+
+ [Fix]
+ A simple tweak to snprintf() formatting from upstream would prevent
+ the theoretical buffer overflow being warned about. This needs applied
+ to disco and eoan; bionic and earlier are not affected.
+
+ [Discussion]
+
+ [Original Report]
+
https://launchpadlibrarian.net/417924491/buildlog_ubuntu-disco-amd64.xen_4.9.2-0ubuntu2_BUILDING.txt.gz
+
+ gcc -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable
-Wno-unused-local-typedefs -O2 -fomit-frame-pointer
-D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
.xen-lowmemd.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Werror -include
/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/config.h
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libs/evtchn/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libxc/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libs/toollog/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libs/foreignmemory/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/libs/devicemodel/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-D__XEN_TOOLS__
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/xenstore/include
-I/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/include
-c -o xen-lowmemd.o xen-lowmemd.c
+ xen-lowmemd.c: In function ‘handle_low_mem’:
+ xen-lowmemd.c:80:55: error: ‘%s’ directive output may be truncated writing up
to 511 bytes into a region of size 489 [-Werror=format-truncation=]
+ snprintf(error, BUFSZ,"Failed to write target %s to xenstore", data);
+ ^~ ~~~~
+ In file included from /usr/include/stdio.h:867,
+ from xen-lowmemd.c:6:
+ /usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note:
‘__builtin___snprintf_chk’ output between 36 and 547 bytes into a destination
of size 512
+ return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
+ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ __bos (__s), __fmt, __va_arg_pack ());
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[5]: ***
[/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc/../../tools/Rules.mk:220:
xen-lowmemd.o] Error 1
make[5]: Leaving directory
'/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/misc'
make[4]: ***
[/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/../tools/Rules.mk:244:
subdir-all-misc] Error 2
make[4]: Leaving directory
'/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools'
make[3]: ***
[/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools/../tools/Rules.mk:239:
subdirs-all] Error 2
make[3]: Leaving directory
'/<<PKGBUILDDIR>>/debian/build/build-utils_amd64/tools'
make[2]: *** [debian/rules.real:111: debian/stamps/build-utils_amd64] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [debian/rules.gen:66: build-arch_amd64_real] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
** Changed in: xen (Ubuntu Eoan)
Assignee: (unassigned) => Bryce Harrington (bryce)
** Changed in: xen (Ubuntu Disco)
Assignee: (unassigned) => Bryce Harrington (bryce)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1823441
Title:
xen ftbfs in disco
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xen/+bug/1823441/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
