Hello Gunnar!

Thanks for the package! This looks good, just two small things I already
poked you about on IRC:

1) debian/watch file. In the package you have overridden the warning
mentioning that the package is no longer maintained upstream - but I see
there is a new release (1.1) done a few days ago. So it feels to me that
the project is once again alive. Might be good to add a watch file in
this case.

2) debian/copyright: at first everything seems to be correct, but after closer 
inspection I noticed two additional developers mentioned in the README file:
Avro JavaScript Phonetic Library by Rifat Nabi
Avro Phonetic Dictionary Search Library by Mehdi Hasan Khan
Checking file avrolib.js, I indeed see "The Initial Developer of the Original 
Code is Rifat Nabi <[email protected]>" and later a copyright notice to 
OmicronLab. We might need to include that in debian/copyright. Not sure about 
the phonetic dictionary - I don't know the code so I'm not sure which file that 
is?

I have rejected it for now. Let's try to fix these issues, reupload and
re-review.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1838570

Title:
  [needs-packaging] ibus-avro

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/1838570/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to