Based on the below items, and the assumption that there is nobody
currently available to actually manually verify this for disco, I'm
marking this as verification-done-disco, although I have not personally
verified it for disco. I leave it up to ~ubuntu-sru team to decide if
this is enough to release the package to disco-updates.
1. existing verification of this patch for bionic (comment 14)
2. the modemmanager codebase being almost identical between bionic and disco:
modemmanager | 1.10.0-1~ubuntu18.04.2 | bionic-updates | source, amd64,
arm64, armhf, i386, ppc64el, s390x
modemmanager | 1.10.0-1ubuntu0.19.04.1 | disco-proposed | source, amd64,
arm64, armhf, i386, ppc64el, s390x
$ git diff --stat pkg/ubuntu/bionic-devel..pkg/ubuntu/disco-devel
debian/changelog | 14 ++++++-------
debian/libmm-glib0.symbols | 236
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------------------------------------------------
debian/patches/error-propagation-fix.patch | 2 +-
3 files changed, 125 insertions(+), 127 deletions(-)
3. the simplicity and obviousness of the patch:
--- a/src/mm-broadband-modem.c
+++ b/src/mm-broadband-modem.c
@@ -8231,7 +8231,7 @@
GError *inner_error = NULL;
gboolean value;
- value = g_task_propagate_boolean (G_TASK (res), error);
+ value = g_task_propagate_boolean (G_TASK (res), &inner_error);
if (inner_error) {
g_propagate_error (error, inner_error);
return FALSE;
** Tags removed: verification-needed
** Tags added: verification-done-disco
** Tags removed: verification-needed-disco
** Tags added: verification-done
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1828102
Title:
Regression in ModemManager
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1828102/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs