Some review: - debdiffs should be attached to the bug (not a gist) - version number should follow https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging - e.g. 2ubuntu0.1, not 2ubuntu1
Unsubscribing ubuntu-sponsors. Once the issues have been addressed, please resubscribe. Personally, I'd also keep the two commits in the one patch separate, makes it easier to check I find the impact too long to read (but it's late). I don't fully comprehend the test cases - is the library header-only so that it needs a rebuild? Otherwise, what happens to existing binaries. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1817595 Title: [SRU] urdfdom-headers and urdfdom should not use locale dependent parsing for floating point numbers To manage notifications about this bug go to: https://bugs.launchpad.net/urdfdom-headers/+bug/1817595/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
