The reason that I argued for the importance to be lowered is that I'm
not super confident about fixing it on a short turnaround without
causing other problems. In disco and before, casper would mount the
entire device (say /dev/sdb) containing the installation media (i.e.
mount /dev/sdb not /dev/sdb1) and that would cause partman base to
exclude /dev/sdb entirely (code around
https://git.launchpad.net/ubuntu/+source/partman-
base/tree/init.d/parted?h=ubuntu/eoan-
proposed&id=ac4be1bb9c00f28d8e19f4ec0c6323769085d593#n156). Now casper
mounts /dev/sdb1 and so that filtering doesn't remove the disk (well,
unless sdb1 fills the device, anyway). It would be possible to cause
that filtering to still exclude the disk but that would break the dell
use case where the installer is in a recovery partition and expects to
install to another partition on the same device (see
https://bugs.launchpad.net/bugs/1846762).
So filtering needs to be added to partman-auto, specifically in
automatically_partition/{replace,reuse,some_device}. The thing is, it
looks like get_auto_disks in lib/auto-shared.sh is _already_ trying to
exclude the device with the install media on it:
# Skip devices containing the installation medium
[ -e "$dev/installation_medium" ] && continue
This file is supposed to be being created by init.d/parted but
apparently isn't. And also fixing this would seem to break the Dell use
case.
And now I'm giving up for now :)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1845571
Title:
ubiquity offers installation media as an install target
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/partman-auto/+bug/1845571/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
