** Description changed: [Impact] The juju plugin will stop and start the juju-db service during data collection. sosreport should not impact running services, or attempt to recover them. This has been reported upstream[0] and will be fixed by the juju 2.x refactor[1] This is a stop-gap tracking the removal of the juju-db service restart code in existing sosreport releases. [0] - https://github.com/sosreport/sos/issues/1653 [1] - https://github.com/sosreport/sos/pull/1670 [Test Case] * Make sure you are in the juju controller. * Install sosreport (if not present already) $ sudo apt-get install sosreport -y * Look mongod PID before $ pidof mongod * Run sosreport, ensuring that the juju plugin is exercised $ sosreport -a # Should detect it if /usr/bin/juju' or '/usr/bin/juju-run' are found and/or $ sosreport -o juju # In a snap package env, it's possible sosreport doesn't detect it and the plugin would need to be enforce. * Confirm the juju-db service was not restarted, and mongoexport data captured by looking mongod PID after $ pidof mongod Check for errors while running, or in /tmp/sosreport-*/sos_logs/ The offending function ensure_service_is_running() in theory doesn't create any harm unless juju plugin is exercised during a sosreport run from a juju controller where mongod and/or juju-db resides. [Regression Potential] * Risk is low. * Change is limited in scope to the juju plugin. * Worst-case scenario is that the mongoexport command will fail to collect any data, which won't affect core functionality of sosreport itself nor impact other sosreport plugins. If any regression, it will be way less worse than current situation, - where daemon are susceptible to be restarted. + where daemon are susceptible to be restarted. It's not sosreport + responsability to take action on daemons, it should only monitor it and + report back to users via its respective plugin. [Other information] We will temporary divert from the juju plugin found upstream and debian, while the refactoring is completed to avoid any situation where sosreport is run on a controller since it may have production impact on Ubuntu juju environment. Once the refactoring of the juju plugin is completed upstream, we will make sure to update debian and put the juju plugin align with what found upstream and debian. Actually, sosreport 3.8 micro-release is blocked waiting for this refactoring to be completed (LP: #1825010).
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828467 Title: [sru] remove juju-db stop/start service interactions To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sosreport/+bug/1828467/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
