Public bug reported:

[Impact]

 * The bump to version 11 exposed an issue of a crash with lsb_output being 
broken.
 * The fix avoids the segfault by validating the pointer before usage

[Test Case]

 * Take a system that runs under VMWare (otherwise it will fast-path skip and 
exit before the bug)
 * Modify /usr/bin/lsb_release to remove e.g. the "-i" option (that would 
trigger the bug)
 * (re)start the vmtoolsd service/program which will crash without the fix

[Regression Potential]

 * The change makes a check before accessing a (potentially bad) pointer. That 
makes it every so 
   slightly slower but it isn't a fast path anyway. The regression risk should 
therefore be rather 
   low. I have discussed with upstream if there also should be a strlen check, 
but that was denied and we are following them on that.

[Other Info]
 
 * We stopped releasing v11 (bug 1844834), I'll generate the uploads in a way 
to have the bug 1844834 included as from a users POV it will be the first time 
v11 hits -updates. Only on Eoan where it is already released the changes file 
to upload will only cover the new bug.
 * Removed some whitespace damage from the upstream change

** Affects: open-vm-tools (Ubuntu)
     Importance: Undecided
         Status: Triaged

** Affects: open-vm-tools (Ubuntu Bionic)
     Importance: Undecided
         Status: Triaged

** Affects: open-vm-tools (Ubuntu Disco)
     Importance: Undecided
         Status: Triaged

** Affects: open-vm-tools (Ubuntu Eoan)
     Importance: Undecided
         Status: Triaged

** Affects: open-vm-tools (Ubuntu Focal)
     Importance: Undecided
         Status: Triaged

** Also affects: open-vm-tools (Ubuntu Bionic)
   Importance: Undecided
       Status: New

** Also affects: open-vm-tools (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Also affects: open-vm-tools (Ubuntu Eoan)
   Importance: Undecided
       Status: New

** Also affects: open-vm-tools (Ubuntu Disco)
   Importance: Undecided
       Status: New

** Changed in: open-vm-tools (Ubuntu Bionic)
       Status: New => Triaged

** Changed in: open-vm-tools (Ubuntu Disco)
       Status: New => Triaged

** Changed in: open-vm-tools (Ubuntu Eoan)
       Status: New => Triaged

** Changed in: open-vm-tools (Ubuntu Focal)
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855686

Title:
  crash on broken lsb_output script

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-vm-tools/+bug/1855686/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to