Test :: xenial $ lsb_release -cs xenial
$ uname -rv 4.4.0-171-generic #200-Ubuntu SMP Tue Dec 3 11:04:55 UTC 2019 $ dpkg -s bcache-tools xfsprogs | grep -i version Version: 1.0.8-2 Version: 4.3.0+nmu1ubuntu1.1 $ sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be' 00002000 58 46 53 42 00 00 10 00 00 00 00 00 00 03 f0 00 |XFSB............| 00007000 fe ed ba be 00 00 00 01 00 00 00 02 00 00 00 14 |................| Before: $ dpkg -s libblkid1 | grep -i version Version: 2.27.1-6ubuntu3.9 $ sudo blkid -o udev -p $BACKING_DEV ID_FS_AMBIVALENT=other:bcache other:xfs_external_log After: $ dpkg -s libblkid1 | grep -i version Version: 2.27.1-6ubuntu3.10 $ sudo blkid -o udev -p $BACKING_DEV ID_FS_UUID=9dd54115-df08-4e6d-99eb-fb322fcfc04e ID_FS_UUID_ENC=9dd54115-df08-4e6d-99eb-fb322fcfc04e ID_FS_TYPE=bcache ID_FS_USAGE=other ** Description changed: [Impact] - * Users with an XFS filesystem on top of bcache - (this is seen on some ceph, cloud deployments) - might fail to reference the bcache device by - UUID or other udev properties. + * Users with an XFS filesystem on top of bcache + (this is seen on some ceph, cloud deployments) + might fail to reference the bcache device by + UUID or other udev properties. - * The journal of the regular XFS filesystem in - the bcache device is incorrectly detected as - an XFS external log; so two superblocks are - detected (bcache and xfs_external_log). + * The journal of the regular XFS filesystem in + the bcache device is incorrectly detected as + an XFS external log; so two superblocks are + detected (bcache and xfs_external_log). - * Thus blkid fails with ambivalent superblocks - detected then doesn't provide the usual udev - properties (UUID, etc.) + * Thus blkid fails with ambivalent superblocks + detected then doesn't provide the usual udev + properties (UUID, etc.) - * The fix improves the probe function for XFS - external log so it detects it's regular XFS - and bails out. + * The fix improves the probe function for XFS + external log so it detects it's regular XFS + and bails out. [Test Case] - * See test steps detailed in comment #. - - Create an XFS filesystem with the journal/log - in the beginning of the bcache device (< 256K). - - Stop the bcache device. - - Run '$ blkid -o udev -p $BCACHE_BACKING_DEVICE'. + * See test steps detailed in comment #7 and later. + - Create an XFS filesystem with the journal/log + in the beginning of the bcache device (< 256K). + - Stop the bcache device. + - Run '$ blkid -o udev -p $BCACHE_BACKING_DEVICE'. - $ sudo make-bcache -B $BACKING_DEV - $ sudo mkfs.xfs -d agsize=16m -l agnum=0 -f $BCACHE_DEV - $ echo 1 | sudo tee /sys/block/$(basename $BCACHE_DEV)/bcache/stop - $ sudo blkid -o udev -p $BACKING_DEV + $ sudo make-bcache -B $BACKING_DEV + $ sudo mkfs.xfs -d agsize=16m -l agnum=0 -f $BCACHE_DEV + $ echo 1 | sudo tee /sys/block/$(basename $BCACHE_DEV)/bcache/stop + $ sudo blkid -o udev -p $BACKING_DEV [Regression Potential] - * The patch only changes the detection function - for XFS external log to be more general about - the sector where the magic of regular XFS may - be found (which is shifted inside the bcache.) + * The patch only changes the detection function + for XFS external log to be more general about + the sector where the magic of regular XFS may + be found (which is shifted inside the bcache.) - * It still checks at sector zero (the only one - checked previously), so this behavior didn't - change. + * It still checks at sector zero (the only one + checked previously), so this behavior didn't + change. - * Possible regressions are actual XFS external - log devices that are not anymore detected as - such. (Although that would probably indicate - a different bug in libblkid.) + * Possible regressions are actual XFS external + log devices that are not anymore detected as + such. (Although that would probably indicate + a different bug in libblkid.) [Other Info] - * upstream commit: - https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/?id=d756af7d640c51ce8d1414607bd3f17eeecf2424 + * upstream commit: + https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/?id=d756af7d640c51ce8d1414607bd3f17eeecf2424 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1858802 Title: libblkid: no bcache UUID due to ambivalent detection of bcache and xfs_external_log for regular xfs in bcache backing device To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1858802/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
