Git commit f15e8568a5330b6795b1dd5287a6a1530dc60476 by Simone Gaiarin. Committed on 25/07/2019 at 18:09. Pushed by gaiarin into branch 'master'.
General improvements to stamp annotation Summary: Configuration: - Add push button to select custom stamp image - Check if loaded image is usable as stamp or throw error - Keep image proportions in previewer - Move previewer below the combobox to display larger preview Annotation tool: - Keep stamp image proportion in annotation preview (while left mouse button is down) - Adding the annotation with one-click (without holding the left mouse button and dragging) adds the stamp with original proportions Related: bug 370381, bug 383652 FIXED-IN: 1.9.0 Closes T8074 TODO: - [ ] Check if filters in file chooser make sense / propose better alternative - [x] Update doc ( @yurchor will do it after we merge this) Test Plan: >From stamp annotation configuration dialog: - Show a warning regarding limitations of the feature's current implementation - Click push button next to combo box opens a file selector - Selecting a corrupted image file should throw an error - Selecting a good image file shows the preview of the image - Select a horizontal image shows a large clear preview - Select a vertical image file shows a smaller preview without messing up the visual of the config dialog - Input a valid icon name in the combobox and the preview of the icon is shown >From page view, select the stamp annotation with horizontal image file (not >squared): - Click and hold. The preview maintains proportions - Single click. The stamp image in the pdf maintains proportions and has the same size of the click and hold preview. - Add an annotation of the Okular custom stamps (internal SVG so treated slightly differently) do not create problems Reviewers: #okular, ngraham Reviewed By: ngraham Subscribers: pino, aacid, yurchor, ngraham, okular-devel Tags: #okular Maniphest Tasks: T8074 Differential Revision: https://phabricator.kde.org/D22064 M +62 -9 ui/annotationwidgets.cpp M +7 -1 ui/annotationwidgets.h M +25 -9 ui/guiutils.cpp M +8 -1 ui/guiutils.h M +1 -1 ui/pagepainter.cpp M +4 -4 ui/pageviewannotator.cpp https://invent.kde.org/kde/okular/commit/f15e8568a5330b6795b1dd5287a6a1530dc60476 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1859632 Title: Stamp annotations cannot be printed to pdf or "flattened" To manage notifications about this bug go to: https://bugs.launchpad.net/okular/+bug/1859632/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
