commit 275bcbebabfb30a171a71d1865c01f10503a96ae
Author: Daniel P. Berrangé <[email protected]>
Date: Thu Aug 1 12:07:47 2019 +0100
tools: fix crash in virt-login-shell if config doesn't exist
If the 'allowed_users' config setting in virt-login-shell.conf
does not exist, we dereference a NULL pointer resulting in a
crash. We should check for this case and thus ensure the user
is denied access gracefully.
Reviewed-by: Michal Privoznik <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
diff --git a/tools/virt-login-shell.c b/tools/virt-login-shell.c
index ee5c04f9c2..b906fa9ed6 100644
--- a/tools/virt-login-shell.c
+++ b/tools/virt-login-shell.c
@@ -54,7 +54,7 @@ static int virLoginShellAllowedUser(virConfPtr conf,
goto cleanup;
- for (entries = users; *entries; entries++) {
+ for (entries = users; entries && *entries; entries++) {
char *entry = *entries;
/*
If string begins with a % this indicates a linux group.
[✓]─[paelzer@Keschdeichel ~/work/libvirt/libvirt-ubuntu-git]──[110885]──[16:09
Di Feb 04]──(detached*)
$ git describe --contains 275bcbebabf
v5.7.0-rc1~356
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1861798
Title:
virt-login-shell crashes
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1861798/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
