Strong packaging practice: despite the missing trailing comma, dh has fail-missing, la files are removed, dh_autoreconf with --as-needed and symbols files present with makeshlibs with -c4. Hardening flags are enabled. The code was part of the upstream gedit code, so OK.
Testsuite is executed during package build. A warning: once promoted to main, -common will be empty in ubuntu, correct as it will be part of our langpacks? (usr/share/locale/ is what is only shipped in it). This may trigger a confusion warning to people using apt in their log, wdyt? I would appreciate overrides over the 2 lintian errors as this is the standard GNOME path (or fix lintian to special case it?) E: libamtk-5-dev: doc-base-file-references-wrong-path amtk:8 /usr/share/gtk-doc/html/amtk-5.0/index.html E: libamtk-5-dev: doc-base-file-references-wrong-path amtk:9 /usr/share/gtk-doc/html/amtk-5.0/*.html So, overall +1 for me, but I would like to have some thoughts about -common (and optionally) that you propose to debian upstream the override for the lintian errors before giving the definitive ack. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862174 Title: [MIR] amtk To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/amtk/+bug/1862174/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs