Time for the formal review ...
[Summary]
The package is small and clean, the function is clear.
I'd be tempted to wonder about security, but you already have a security Ack.
Therefore I'm MIR-Acking this as well, as formally it seems fine to me.
There are still a few TODOs (not gating the MIR):
- further confinement would be nice to have
- are there tests anywhere that would e.g. catch if systemd changes?
If yes please point to them, if no could you consider adding some?
[Duplication]
There is no other package in main providing the same functionality.
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
[Security]
OK:
- history of CVEs does not look concerning
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
Problems:
- does run a daemon as root and executes externally controlled content
I have outlined that in comment #4 already.
Any further confinement that you could add which does not break your
intended use case would be helpful.
- Empty CVE history for a package a few days old doesn't actually count :-)
[Common blockers]
OK:
- does not FTBFS currently
- The package has a team bug subscriber
- no translation present, but none needed for this case (user visible)?
- not a python package, no extra constraints to consider int hat regard
- no new python2 dependency
Problems:
- does not have a test suite that runs at build time
- does not have a test suite that runs as autopkgtest
=> I assume you exercise that in LXD tests somewhere?
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- Ubuntu does carry a delta, but it is reasonable and maintenance under control
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok
- Ubuntu update history is too short to evaluate, but it is owned by one
of our teams so it should be fine
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- d/rules is rather clean
- Does not have Built-Using
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as I can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- no embedded source copies
- not part of the UI for extra checks
** Changed in: lxd-agent-loader (Ubuntu)
Assignee: Christian Ehrhardt (paelzer) => (unassigned)
** Changed in: lxd-agent-loader (Ubuntu)
Status: New => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1868572
Title:
[MIR] lxd-agent-loader
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd-agent-loader/+bug/1868572/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
