Re-testing against the updated PPA version, rebuilt locally:
0. √ Source package unpacked ok
1. √ Build worked ok
2. √ The .deb file manual installation worked ok
3. √ Downgrading the package works ok
4. ! tox hit an ERROR
5. √ autopkgtest passed ok
6. √ Review of changes vs. prior release
== Details ==
0. Source package unpacked ok
No stray changes, files appear to match git tree
1. Build worked ok.
All build tests passed 100%
debuild shows a few warnings and errors:
Now running lintian ubuntu-advantage-tools_20.3_amd64.changes ...
E: ubuntu-advantage-tools: no-debconf-config
E: ubuntu-advantage-tools source: not-using-po-debconf
E: ubuntu-advantage-tools source: untranslatable-debconf-templates
ubuntu-advantage-tools.templates: 3
W: ubuntu-advantage-tools source: build-depends-on-obsolete-package
build-depends: dh-systemd => use debhelper (>= 9.20160709)
W: ubuntu-advantage-tools source: debhelper-but-no-misc-depends
ubuntu-advantage-pro
W: ubuntu-advantage-tools: postinst-uses-db-input
W: ubuntu-advantage-tools: uses-dpkg-database-directly
usr/lib/python3/dist-packages/uaclient/apt.py
I think these can probably be ignored for 20.3 but you might look into
them for future releases.
2. The .deb file manual installation worked ok
$ sudo dpkg -i ubuntu-advantage-tools_20.3_amd64.deb
(Reading database ... 60450 files and directories currently installed.)
Preparing to unpack ubuntu-advantage-tools_20.3_amd64.deb ...
Unpacking ubuntu-advantage-tools (20.3) over (20.2.1~0ubuntu1) ...
Setting up ubuntu-advantage-tools (20.3) ...
/usr/lib/python3.8/subprocess.py:838: RuntimeWarning: line buffering
(buffering=1) isn't supported in binary mode, the default buffer size will be
used
self.stdin = io.open(p2cwrite, 'wb', bufsize)
Processing triggers for man-db (2.9.1-1) ...
(That warning is unrelated to ua-tools, it is something in focal that
seems to come up for all python packages.)
3. Downgrading the package works ok:
$ sudo apt-get install ubuntu-advantage-tools=20.2.1~0ubuntu1
...
Unpacking ubuntu-advantage-tools (20.2.1~0ubuntu1) over (20.3) ...
Setting up ubuntu-advantage-tools (20.2.1~0ubuntu1) ...
/usr/lib/python3.8/subprocess.py:838: RuntimeWarning: line buffering
(buffering=1) isn't supported in binary mode, the default buffer size will be
used
self.stdin = io.open(p2cwrite, 'wb', bufsize)
Processing triggers for man-db (2.9.1-1) ...
4. tox had some flake8 errors
$ tox
...
File
"/home/bryce/ubuntu/UATools/ubuntu-advantage-tools-20.3/.tox/flake8-xenial/lib/python3.8/site-packages/pyflakes/checker.py",
line 462, in getNodeHandler
self._nodeHandlers[node_class] = handler = getattr(self, nodeType)
AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'
ERROR: InvocationError for command
/home/bryce/ubuntu/UATools/ubuntu-advantage-tools-20.3/.tox/flake8-xenial/bin/flake8
uaclient setup.py (exited with code 1)
...
All done! ✨ 🍰 ✨
63 files would be left unchanged.
______________________________________________________ summary
______________________________________________________
py3: commands succeeded
flake8: commands succeeded
py3-xenial: commands succeeded
py3-bionic: commands succeeded
py3-eoan: commands succeeded
flake8-trusty: commands succeeded
ERROR: flake8-xenial: commands failed
ERROR: flake8-bionic: commands failed
flake8-eoan: commands succeeded
mypy: commands succeeded
black: commands succeeded
The flake error doesn't strike me as important, but I'm not sure what
exactly it's complaining about.
5. autopkgtest passed ok
$ sudo autopkgtest -U --shell-fail . -- null
...
++ ua version
20.3
autopkgtest [00:56:27]: test usage: -----------------------]
autopkgtest [00:56:27]: test usage: - - - - - - - - - - results - - - - - - -
- - -
usage PASS
autopkgtest [00:56:27]: @@@@@@@@@@@@@@@@@@@@ summary
usage PASS
6. Review of changes vs. prior release
$ debdiff ubuntu-advantage-tools_20.2.1~0ubuntu1.dsc
ubuntu-advantage-tools_20.3.dsc > ubuntu-advantage-tools_20.3.debdiff
$ diffstat ubuntu-advantage-tools_20.3.debdiff
...
1635 files changed, 573 insertions(+), 532176 deletions(-)
Daaaang. So, I used this command to filter out the insertions to look
at:
$ cat ubuntu-advantage-tools_20.3.debdiff | grep "^+ "
$ git show 5881e7760c89a7ef64439b97ec44b45aea290a55
These match up, and a quick code review of the changes spotted nothing
of concern.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1869980
Title:
New upstream release: 20.3 for focal
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1869980/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
