On Sat, Apr 04, 2020 at 07:42:04PM -0000, Bryce Harrington wrote: > I've code-reviewed and tested Brian's fix, and it LGTM and WFM. Tested > both with a catted text file, and URLs displayed via Mutt (i.e. > ncurses). > > The patch also applies cleanly to the upstream terminator tree. The > test suite is py2 only so I could not run it, however the codebase > builds cleanly. I installed to /usr/local/bin and verified the patched > upstream terminator works properly for url highlighting. > > I did notice 9 instances of the following warning: > > $ /usr/local/bin/terminator --no-dbus > (terminator:3493042): VTE-WARNING **: 12:33:26.006: > (../src/vtegtk.cc:2173):int vte_terminal_match_add_regex(VteTerminal*, > VteRegex*, guint32): runtime check failed: > (_vte_regex_has_multiline_compile_flag(regex)$ /usr/local/bin/terminator > --no-dbus) > > At least some of these occur around when the URL plugins are loaded, > others occur earlier I guess.
I've found the fix for this too and incorporated it into my PPA. When I say I literally mean found - somebody has forked terminator. https://github.com/JAugusto42/terminator/commit/525a591d97b0c46d22edead1f33b03c9ce01144b #diff-bdc83e01c58f95d15c371b67be1b0a53 > Anyway, based on the debdiff review, +1 to landing this in Ubuntu 20.04. I'll do that this weekend or Monday. > I can also land this to upstream's master bzr tree, if you'd like? Sure, I'm fine with that. -- Brian Murray -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1867746 Title: URL highlighting broken with VTE 0.60 To manage notifications about this bug go to: https://bugs.launchpad.net/terminator/+bug/1867746/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
