Comment on attachment 394269
Patch

View in context:
https://bugs.webkit.org/attachment.cgi?id=394269&action=review

> Source/WTF/ChangeLog:11
> +        will be even easier to detect if we change 
> RELEASE_ASSERT_WITH_MESSAGE() to actually print

We should not change RELEASE_ALERT_WITH_MESSAGE() to unconditionally
print its message.  That message is only meant to be used in debug
builds.  But if you really want a message in a release build, you can
always check the condition first and print your message before doing the
RELEASE_ASSERT.  I do not recommend doing this in the general case (for
performance reasons), but in your implementation here, it’ll only be
executed once.  So checking and printing that error message won’t hurt
much.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1868108

Title:
  [autopkgtest][focal] ruby-gnome/3.4.1-2build1
  class:TestWebKit2GtkWebView failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/webkit/+bug/1868108/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to