@ddstreet I appreciate your quick response and detailed guidance. The
description is updated. Thanks.

** Description changed:

  [impact]
  
  thermald doesn't support Tiger Lake cpus
  
  [test case]
  
  run thermald on Tiger Lake cpu
  
+ It can be check by following command, and the patch works if it return 
"passed".
+ $ systemctl is-active --quiet thermald && echo passed
+ 
  [regression potential]
  
- and regression would likely involve incorrect support for Tiger Lake
- cpus
+ because TGL is not supported so current thermald is not working on TGL.
+ So, there's not potential regression for this patch to make it works.
  
  [scope]
  
  needed for F/G
  
  [original description]
  
  need the patch to support Intel TGL CPU on Focal
  
  https://github.com/intel/thermal_daemon/blob/master/src/thd_engine.cpp#L666

** Description changed:

  [impact]
  
  thermald doesn't support Tiger Lake cpus
  
  [test case]
  
  run thermald on Tiger Lake cpu
  
- It can be check by following command, and the patch works if it return 
"passed".
+ It can be checked by following command, and the patch works if it return 
"passed".
  $ systemctl is-active --quiet thermald && echo passed
  
  [regression potential]
  
  because TGL is not supported so current thermald is not working on TGL.
  So, there's not potential regression for this patch to make it works.
  
  [scope]
  
  needed for F/G
  
  [original description]
  
  need the patch to support Intel TGL CPU on Focal
  
  https://github.com/intel/thermal_daemon/blob/master/src/thd_engine.cpp#L666

** Description changed:

  [impact]
  
  thermald doesn't support Tiger Lake cpus
  
  [test case]
  
  run thermald on Tiger Lake cpu
  
  It can be checked by following command, and the patch works if it return 
"passed".
  $ systemctl is-active --quiet thermald && echo passed
  
  [regression potential]
  
- because TGL is not supported so current thermald is not working on TGL.
- So, there's not potential regression for this patch to make it works.
+ because TGL is not supported by current thermald, so thermald always inactive 
on TGL platform. This patch is to activate it.
+ So, there's not potential regression.
  
  [scope]
  
  needed for F/G
  
  [original description]
  
  need the patch to support Intel TGL CPU on Focal
  
  https://github.com/intel/thermal_daemon/blob/master/src/thd_engine.cpp#L666

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1876066

Title:
  Support Intel TGL CPU on Focal

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1876066/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to