This looks good. Thank you to everyone involved for working through such a complex issue. In particular, since python-certbot-nginx is believed to be completely broken in Focal at the moment, it is unlikely that we will regress it further and this is a nice minimal fix, so it seems unlikely that we will regret landing this. The actual upstream changes being adopted - particular the functional changes (one line!) - seem specific to one issue and minor in scope.
One minor comment: > -ifdef (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) > +ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) I see this fix is not yet present in Groovy, but it is fixed in Debian VCS https://salsa.debian.org/letsencrypt-team/certbot/certbot- nginx/-/commit/72853775b81f04232d5d63ebeaa683003310dfbe (thank you!) and this won't cause a functional regression for users upgrading to Groovy, so I think this is acceptable for the SRU. ** Also affects: python-certbot-nginx (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: python-certbot-nginx (Ubuntu) Status: In Progress => Fix Released ** Changed in: python-certbot-nginx (Ubuntu Focal) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1875471 Title: python3-certbot-nginx is incompatible with its dependencies To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-certbot-nginx/+bug/1875471/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
