Hi Garry,
why thanks for the patch - I was missing that update earlier in the year and 
beg your pardon.

#1
Why did you drop the "load the storage driver so that backing store can be 
accessed" section - that will continue to be needed at least for other storage 
types so I wonder why this was dropped.

#2
/etc/libvirt/libvirt.conf usually only defins URIs, that isn't needed unless we 
have a change that starts to have virt-aa-helper to re-query libvirt (and even 
then there might be multiple libvirts running and you can't know it is "this 
config file").
Will that be read by the virGetConnectStorage call in 
virDomainDiskTranslateSourcePool of your diff?

#3 around virDomainDiskTranslateSourcePool
I see, interesting approach.
So you'd want to translate the source pool into the disk struct.
And if it isn't a pool it will be an early exit with RC=0 and go on as usual
Do you have an example from the disk structure content from before/after your 
changes?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1677398

Title:
  Apparmor prevents using storage pools and hostdev networks

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1677398/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to