This is the diff I intend to SRU in focal.

Basically its the same as the groovy one. 
Restore of a pegjs binary in usr/bin (Debian bug: #959615)
Restore recommendation of javascript-common (Debian bug: #956507)
Drop useless lintian overrides.

Drop nodejs provide and recommend it instead
--- pegjs-0.10.0/debian/changelog       2020-04-04 12:58:52.000000000 +0200
+++ pegjs-0.10.0/debian/changelog       2020-05-26 13:29:03.000000000 +0200
@@ -1,3 +1,23 @@
+pegjs (0.10.0-3~ubuntu1.20.04.1) focal; urgency=medium
+
+  * SRU Upload to Ubuntu focal (LP: #1880680)
+
+ -- Gianfranco Costamagna <[email protected]>  Tue, 26 May 2020 
13:29:03 +0200
+
+pegjs (0.10.0-3) unstable; urgency=medium
+
+  * Restore /usr/bin/pegjs (Closes: #959615)
+  * Remove nodejs from dependencies and add javascript-common as recommended
+    dependency (Closes: #722488)
+
+ -- Xavier Guimard <[email protected]>  Sun, 03 May 2020 16:01:16 +0200
+
+pegjs (0.10.0-2) unstable; urgency=medium
+
+  * Fix dependencies (Closes: #956507)
+
+ -- Xavier Guimard <[email protected]>  Sun, 12 Apr 2020 10:31:49 +0200
+
 pegjs (0.10.0-1) unstable; urgency=medium

   * Bump debhelper compatibility level to 12
diff -Nru pegjs-0.10.0/debian/control pegjs-0.10.0/debian/control
--- pegjs-0.10.0/debian/control 2020-04-04 12:54:42.000000000 +0200
+++ pegjs-0.10.0/debian/control 2020-05-03 16:01:16.000000000 +0200
@@ -17,10 +17,10 @@
 Package: node-pegjs
 Architecture: all
 Depends: ${misc:Depends}
+Recommends: javascript-common
 Provides: node-peg
  , pegjs
  , libjs-pegjs
- , nodejs
 Description: JavaScript parser generator
  PEG.js is a simple parser generator for JavaScript that produces
  fast parsers with excellent error reporting. You can use it to process
diff -Nru pegjs-0.10.0/debian/lintian-overrides 
pegjs-0.10.0/debian/lintian-overrides
--- pegjs-0.10.0/debian/lintian-overrides       2020-04-04 12:56:50.000000000 
+0200
+++ pegjs-0.10.0/debian/lintian-overrides       1970-01-01 01:00:00.000000000 
+0100
@@ -1,2 +0,0 @@
-# Binary not installed
-node-pegjs: manpage-without-executable usr/share/man/man1/pegjs.1.gz
diff -Nru pegjs-0.10.0/debian/nodejs/links pegjs-0.10.0/debian/nodejs/links
--- pegjs-0.10.0/debian/nodejs/links    1970-01-01 01:00:00.000000000 +0100
+++ pegjs-0.10.0/debian/nodejs/links    2020-05-03 16:00:26.000000000 +0200
@@ -0,0 +1 @@
+pegjs/bin/pegjs /usr/bin/pegjs
                                                                                
                                                                                
                          53,1          Bot


** Summary changed:

- Pegjs should not provide nodejs.
+ [SRU] Pegjs should not provide nodejs.

** Changed in: pegjs (Ubuntu Focal)
       Status: New => In Progress

** Description changed:

- pegjs in focal provides nodejs breaking the world when installed.
+ 
+ [Impact] 
+ 
+ * There is no nodejs provided by pegjs, even if the pegjs binary seems to say 
so.
+ * There is missing usr/bin/pegjs binary
+ 
+ [Test Case]
+ 
+  * Use nodejs libraries with just pegjs installed will show this bug (nodejs 
dependency wrongly satisfied)
+  
+ [Regression Potential] 
+ 
+  * Really, Really, none.
+ It will increase uninstallability of riscv64, because nodejs is not built 
there. But this is really what we want, because no nodejs library can run 
without a nodejs interpreter.
+ 
+ [Other Info]
+  
+  * pegjs in focal provides nodejs breaking the world when installed.
+  * I prefer to keep the binary the same as the groovy one, fixing the same 
bugs fixed in the Debian upload. And described in the Impact section.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1880680

Title:
  [SRU] Pegjs should not provide nodejs.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pegjs/+bug/1880680/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to