Public bug reported: [Impact]
The KVM plugin get triggered in a container (e.g lxd) because of "/sys/module/kvm" inheritance from the kernel host. Not only it's a waste of sosreport time, but running it inside a container may unintentionally reveal details from its host. Which is a undesired behaviour. Switching to /dev/kvm, is more appropriate and follow current standard as used by tool such as cpu-checker (kvm-ok) for instance. And taking benefit of this change to get rid of the check_enabled() overwrite in favour of using "files=" trigger. [Test Case] * Run sosreport inside a LXD container * The container will contain KVM information from its host (Iff its host as KVM installed) [Regression Potential] We only change the way the plugin gets triggered to use a most conventional way. If /dev/kvm exist, then exercise the kvm plugin. No regression expected, but worse case scenario, it will only be isolated and impact the KVM plugin to collect data properly as expected. It won't cause any harm to others plugins nor sosreport core functionalities itself. The commit went through some upstream Travis testing which used a shell script called "simple.sh" to verify sosreport collection. BTW, this same exact script is part of the sosreport autopkgtest, and will be run as part of the SRU to push this change. [Other Information] * Upstream bug: https://github.com/sosreport/sos/issues/2062 * Upstream commit: https://github.com/sosreport/sos/pull/2063/commits/dc58a038c18ff3e838d883d4b31aad5dac7ea9e1 ** Affects: sosreport (Ubuntu) Importance: Undecided Assignee: Eric Desrochers (slashd) Status: In Progress ** Affects: sosreport (Ubuntu Xenial) Importance: Undecided Status: New ** Affects: sosreport (Ubuntu Bionic) Importance: Undecided Status: New ** Affects: sosreport (Ubuntu Focal) Importance: Undecided Status: New ** Affects: sosreport (Ubuntu Groovy) Importance: Undecided Assignee: Eric Desrochers (slashd) Status: In Progress ** Tags: seg sts ** Tags added: seg sts ** Changed in: sosreport (Ubuntu) Assignee: (unassigned) => Eric Desrochers (slashd) ** Changed in: sosreport (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883320 Title: [kvm] change check_enabled to /dev/kvm To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sosreport/+bug/1883320/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
