** Description changed: + == SRU Justification (Bionic) == + + Building Bionic SPL with 5.4 kernels breaks because 5.4 removed the + user_path_dir inlined helper. + + == Fix == + + Replace the deprecated inline helper user_path_dir() (not in Linux 5.4) + with the more stable generic variant user_path_at_empty(). The latter + function has not changed from 4.15.. to present, so it's a more verbose + call but semantically identical. + + == Testcase == + + Build with a 5.4+ kernel. Without the fix dkms will fail to build. With + the fix it will build successfully. Once built, test with the ubuntu + autotest ZFS tests, it will pass. Also test on mainline 4.15 and 5.3, + 5.4 kernels that don't have ZFS built-in (from https://kernel.ubuntu.com + /~kernel-ppa/mainline) + + == Regression Potential == + + Very small. We are effectively replacing the call to an inlined helper + function user_path_dir with the same underlying more generic call in the + kernel, so basically this is a one-to-one mapping of the original inline + helper to the more generic version. The resulting generated object code + is effectively the same. + + ---------- + + Testing failed on: amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/s/spl-linux/20200625_151633_f3515@/log.gz arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/arm64/s/spl-linux/20200625_151231_d6324@/log.gz i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/i386/s/spl-linux/20200625_155905_74965@/log.gz ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/ppc64el/s/spl-linux/20200625_132916_ebca2@/log.gz s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/s390x/s/spl-linux/20200625_132800_3905e@/log.gz Build error: /var/lib/dkms/spl/0.7.5/build/module/spl/spl-vnode.c: In function ‘vn_set_pwd’: /var/lib/dkms/spl/0.7.5/build/module/spl/spl-vnode.c:830:14: error: implicit declaration of function ‘user_path_dir’; did you mean ‘user_path_at’? [-Werror=implicit-function-declaration] - rc = user_path_dir(filename, &path); - ^~~~~~~~~~~~~ - user_path_at + rc = user_path_dir(filename, &path); + ^~~~~~~~~~~~~ + user_path_at
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1885285 Title: spl-linux 0.7.5-1ubuntu2.1 ADT test failure with 5.4 kernels in Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/spl-linux/+bug/1885285/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
