> > well IMHO it is a bug to have the file in the orig tarball > > Agreed, but aren't you tracking that in bug 1887535? What are you expecting > to see changed that will, in your eyes, resolve _this_ bug?
that bug is different, the configure and Makefile actually behave differently if there is a top-level '.git' directory > This bug is an example of a source package that changes behaviour depending on > whether the .git exists or not this bug is about a file 'ui/keycodemapdb/.git', not a top-level .git file/dir, and the existence of that lower-level .git file does not affect the actual build (it only breaks dpkg-source's attempt to apply all patches and verify there are no local changes). the other bug is about the existence (or not) of a top-level .git directory, which is not related to git-ubuntu's behavior of creating a '..git' file/dir. (and also, the build acting differently if a top-level .git exists or not is itself a bug) > I consider that (a) would make git-ubuntu fundamentally broken, so (b) is the least worst choice. yep, it's a difficult choice; possibly git-ubuntu could cause a warning to be output after a 'git checkout' and maybe 'git reset' if it detects there is a '..git' file/dir that is a result of such git-ubuntu escaping. It was confusing to me that the build failure happened, and I assume would be confusing to others using git-ubuntu but building with traditional tooling. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887823 Title: bionic git-ubuntu checkout has '..git' file in subfolder that causes build failure To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1887823/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
