@rafaeldtinoco if you have a minute could you review the upload for this for focal? specifically, because the 1.9-1 package version included hardcoded (generated at build time) uuid in /etc/nvme/hostid, i added code in the postinst to replace that value with a install-time generated uuid (so it's unique per host system). http://launchpadlibrarian.net/495790426/nvme-cli_1.9-1_1.9-1ubuntu0.1.diff.gz
My concern is what the impact might be for anyone actually using the hardcoded hostid uuid, and if it's better to just leave the old (non- unique) hostid instead of forcibly replacing it with a unique id. I will note that in groovy, i didn't add any code to replace existing hardcoded hostid; any groovy system that started with the 1.12-1 package version will keep the non-unique hostid. However since groovy isn't released yet, any groovy system installed after GA would get the fixed package (and a unique hostid uuid). In bionic, the package doesn't create /etc/nvme/* files so it's not an issue there; in fact, the /etc/nvme/* files don't appear to have been created for any version earlier than focal, so the 1.9-1 and 1.12-1 versions appear to be the only ones containing non-unique /etc/nvme/hostid values (and no version contained anything in the /etc/nvme/hostnqn file, since the 'gen-hostnqn' command has always been broken until fixed in 1.12-1ubuntu1) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1867366 Title: hostnqn fails to automatically generate after installing nvme-cli To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/1867366/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
