Reviewed: https://review.opendev.org/750216 Committed: https://git.openstack.org/cgit/openstack/oslo.utils/commit/?id=632f15515fb224863c1027c658858c595ad5d11b Submitter: Zuul Branch: master
commit 632f15515fb224863c1027c658858c595ad5d11b Author: Ghanshyam Mann <[email protected]> Date: Mon Sep 7 16:15:20 2020 -0500 Fix is_same_callback() testing for python3.8 Python3.8 onwards, comparision of bound methods is changed. It no longer decide the bound method's equality based on their bounded objects equality instead it checks the identity of their '__self__'. Details about this behavior change in python 3.8 - https://bugs.python.org/issue1617161 - python-dev discussion: https://mail.python.org/pipermail/python-dev/2018-June/153959.html So python3.8 onwards, 'strict' arg has no meaning. For backward compatibility for python <3.8, we can keep the 'strict' arg but with deprecation warning. Also modify the is_same_callback() unit tests to verify the 'strict' arg based on python version. Change-Id: I3e6d9bbceccacddd0e1a514bbe5d0722a3408ecb Closes-Bug: #1841072 ** Changed in: oslo.utils Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1841072 Title: test_reflection.CallbackEqualityTest.test_different_instance_callbacks fails on Python 3.8 To manage notifications about this bug go to: https://bugs.launchpad.net/oslo.utils/+bug/1841072/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
