I'm still really confused by this but some thoughts on the nova
os.chmod() call mentioned in an earlier commit that would fix this.

If I chmod the tmp dir that gets created by nova (e.g.
/var/lib/nova/instances/snapshots/tmpkajuir8o) to 755 just before the
snapshot (after the nova chmod), the snapshot is successful.

As mentioned in
https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1896617/comments/18,
the upstream nova code sets permissions for the tmp dir with:

os.chmod(tmpdir, 0o701)

That code has been that way since 2015, so it's not new in ussuri, see
git blame:

824c3706a3e nova/virt/libvirt/driver.py     (Nicolas Simonds               
2015-07-23 12:47:24 -0500  2388)                         # NOTE(xqueralt): 
libvirt needs o+x in the tempdir
824c3706a3e nova/virt/libvirt/driver.py     (Nicolas Simonds               
2015-07-23 12:47:24 -0500  2389)                         os.chmod(tmpdir, 0o701)

However, this seems like a heavy handed chmod if the goal, as the
comment above it mentions, is to give libvirt o+x in the tempdir. I say
this because it overrides any default permissions that were set
previously by the operating system.

It seems that this should really be a lighter touch such as the
following (equivalent to chmod o+x tmpdir):

st = os.stat(tmpdir)
os.chmod(tmpdir, st.st_mode | stat.S_IXOTH)

That would fix this bug for us, but still doesn't explain what changed
in Ubuntu to cause this to fail. We did make some permissions changes in
the nova package in focal but as compared above (with ussuri-proposed)
file/directory permissions above in comment #21 I'm seeing no
differences.

** Changed in: nova
       Status: Invalid => New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1896617

Title:
  Creation of image (or live snapshot) from the existing VM fails if
  libvirt-image-backend is configured to qcow2 starting from Ussuri

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-nova-compute/+bug/1896617/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to