** Description changed:
[Impact]
- Other php SRUs end up blocked from migration due to a test case in php-
- parser that fails due to an integer format mismatch.
-
+ Other PHP SRUs are being blocked due to test failures in php-parser.
+ The test case failures appear to be due to irregularities with integer
+ parsing particular to the test framework rather than identifying actual
+ bugs.
[Test Case]
1. Create lxc container for ubuntu-focal
2. Install php-parser
3. Run autopkgtest php-parser -- null
The testsuite should pass but it does not, and fails with several
invalid token lexer cases starting with and similar to this one:
1) PhpParser\CodeParsingTest::testParse with data set
"tmp/autopkgtest.eZ6NuZ/build.Ar8/src/test/code/parser/errorHandling/lexerErrors.test#1"
('Lexer errors (/tmp/autopkgtes....test)', Binary String:
0x3c3f7068700a0...032343b, Binary String: 0x556e657870656...0290a29, null)
RangeException: The lexer returned an invalid token (id=320, value=)
/usr/share/php/PhpParser/ParserAbstract.php:216
/usr/share/php/PhpParser/ParserAbstract.php:158
/tmp/autopkgtest.eZ6NuZ/build.Ar8/src/test/PhpParser/CodeParsingTest.php:58
/tmp/autopkgtest.eZ6NuZ/build.Ar8/src/test/PhpParser/CodeParsingTest.php:21
+ The build system also runs the test suite, so an alternative way to
+ reproduce the failure is to do a package build of php-parser in lxc.
+
[Regression Potential]
- Since this is a testsuite fix for integer parsing on armhf, the two
- things to watch for would be a) issues relating to the testsuite, or b)
- issues particular to armhf (especially traceable to integer parsing
- behavior). However, in the first case, the testsuite's behavior would
- crop up only during building / migrating in the archive and would not
- produce user-visible effects. In the second case, integer parsing
- issues already exist in released code so would not be a true regression,
- the test case only exposes them - by preventing other php packages from
- migrating.
+ Since this is a testsuite fix for integer parsing, the two things to
+ watch for would be a) issues relating to the testsuite, or b) issues
+ particular to integer parsing behavior. However, in the first case, the
+ testsuite's behavior would crop up only during building / migrating in
+ the archive and would not produce user-visible effects. In the second
+ case, integer parsing issues already exist in released code so would not
+ be a true regression, the test case only exposes them - by preventing
+ other php packages from migrating.
[Discussion]
php-parser's autopkgtest has been failing in focal on armhf for some
time:
http://autopkgtest.ubuntu.com/packages/p/php-parser/focal/armhf
The test failure is due to an integer format mismatch. We spotted this
issue on groovy and flagged it for upstream:
https://github.com/nikic/PHP-Parser/issues/662
There doesn't appear to be a fix identified yet. We addressed it in
groovy by disabling the faulty tests (the one listed in this bug, and
the one in LP: #1878102), and that may be a low-risk way to address it
for focal, too.
https://launchpad.net/ubuntu/+source/php-parser/4.4.0-1ubuntu2
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1895878
Title:
[SRU] Integer parsing failure on armhf blocks autopkgtests on focal
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/php-parser/+bug/1895878/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
