** Description changed: [Impact] - * Currently Ubuntu Bionic does not have fence_aws available and that is + * Currently Ubuntu Bionic does not have fence_aws available and that is needed in order to have a fully working HA solution in AWS environment. - * fence_aws from Focal fence-agents (4.5.2-1) is missing some important - fixes that happened in between Focal and Groovy versions. With that, I - opted to fully bring all the fixes from version 4.6.0 to Focal and - backport this same version to Bionic (this way Bionic and Focal are in - the same level also). + * fence_aws from Focal fence-agents (4.5.2-1) is missing some fixes + that happened in between Focal and Groovy versions. With that, I + initially opted to fully bring all the fixes from version 4.6.0 to Focal + and backport this same version to Bionic (this way Bionic and Focal were + in the same level). + + * After MR reviews, thinking about the SRU review, I agreed to minimize + this change making Ubuntu Bionic fence_aws agent just like focal and + working in any needed Focal fix for fence_aws (as long as there was a + test case for it). [Test Case] - * Provision 3 nodes in AWS with Ubuntu Focal (and Ubuntu Bionic) and + * Provision 3 nodes in AWS with Ubuntu Focal (and Ubuntu Bionic) and configure it adding the following primitive as a fencing resource: primitive fence-focal stonith:fence_aws params access_key="xxxx" secret_key="yyyy" region="us-east-1" pcmk_host_map="focal01:i-034dc89cca4310b03;focal02:i-0a160b14b40f1330a;focal03:i-03b6976ab0a7f377c" and the cluster cib options: property cib-bootstrap-options: \ - have-watchdog=false \ - cluster-infrastructure=corosync \ - stonith-enabled=on \ - stonith-action=reboot \ - no-quorum-policy=stop \ - cluster-name=bionic + have-watchdog=false \ + cluster-infrastructure=corosync \ + stonith-enabled=on \ + stonith-action=reboot \ + no-quorum-policy=stop \ + cluster-name=bionic - * After that you can remove the interconnect of one of the nodes and + * After that you can remove the interconnect of one of the nodes and watch the cluster to shutdown the node that was disconnected from the cluster ring. [Regression Potential] - * Focal wise: + * Bionic wise: - - We're only touching agents/aws/fence_aws.py and - tests/data/metadata/fence_aws.xml files. This reduces *a lot* the scope - of the code change and helps in the SRU approval (as the change is - confined into the aws fence agent only). - - - Biggest problem here could be related to rebuilds, as the fence- - agents are directly called from pacemaker as "exec'ed scripts with right - arguments", and there is no change to any part of the fence-agents core - package. - - * Bionic wise: - - - Same as focal, but here it is even better situation as there isn't + - Same as focal, but here it is even better situation as there isn't an existing fence_aws agent. Biggest problem here could be introduce something that does not fully work (which is technically not a regression). [Other Info] - This is a request from AWS to backport existing fence_aws agent into - Bionic: - - ---- - commit 50772024 - Author: Oyvind Albrigtsen <oalbr...@redhat.com> - Date: Mon May 25 12:07:14 2020 - - fence_aws: improve boto3_debug boolean handling - - commit be206158 - Author: Oyvind Albrigtsen <oalbr...@redhat.com> - Date: Mon May 25 12:03:53 2020 - - fence_aws: catch ConnectionError and suppress traceback for caught - exceptions - - commit 9758f8c8 - Author: Oyvind Albrigtsen <oalbr...@redhat.com> - Date: Tue Mar 24 14:31:13 2020 - - fence_aws: fix Python 3 encoding issue - - commit 3f5676a7 - Author: gguifelixamz <45173771+gguifelix...@users.noreply.github.com> - Date: Fri Mar 20 14:41:07 2020 - - fence_aws: Fix fence race, logging improvement and new debug option - (#323) - - * fence_aws: Fix fence race condition by checking local instance status - * fence_aws: Use local logger and improve logging experience - * fence_aws: Decouple boto3 and botocore debug logging from local logging - - commit 1c2f791b - Author: Oyvind Albrigtsen <oalbr...@redhat.com> + This is a request from AWS to backport existing fence_aws agent into Bionic: + @redhat.com> Date: Thu Mar 5 13:10:29 2020 fence_aws: improve connect parameter logic, so region can be specified as parameter, while using role or keys from ~/.aws/config commit 7ac16fb2 Author: Oyvind Albrigtsen <oalbr...@redhat.com> Date: Fri Jan 31 14:53:47 2020 fence_aws: improve logging and metadata/usage text commit a3f45322 Author: Oyvind Albrigtsen <oalbr...@redhat.com> Date: Tue Mar 7 10:04:49 2017 fence_aws: new agent ---- Currently fence-agents Ubuntu Bionic version is at: 4.0.25-2ubuntu1 and the fence_aws new agent started at: $ git tag --contains a3f45322 | head -1 v4.1.0
** Description changed: [Impact] * Currently Ubuntu Bionic does not have fence_aws available and that is needed in order to have a fully working HA solution in AWS environment. * fence_aws from Focal fence-agents (4.5.2-1) is missing some fixes that happened in between Focal and Groovy versions. With that, I initially opted to fully bring all the fixes from version 4.6.0 to Focal and backport this same version to Bionic (this way Bionic and Focal were in the same level). - * After MR reviews, thinking about the SRU review, I agreed to minimize + * After MR reviews, thinking about the SRU review, I agreed to minimize this change making Ubuntu Bionic fence_aws agent just like focal and working in any needed Focal fix for fence_aws (as long as there was a test case for it). [Test Case] * Provision 3 nodes in AWS with Ubuntu Focal (and Ubuntu Bionic) and configure it adding the following primitive as a fencing resource: primitive fence-focal stonith:fence_aws params access_key="xxxx" secret_key="yyyy" region="us-east-1" pcmk_host_map="focal01:i-034dc89cca4310b03;focal02:i-0a160b14b40f1330a;focal03:i-03b6976ab0a7f377c" and the cluster cib options: property cib-bootstrap-options: \ have-watchdog=false \ cluster-infrastructure=corosync \ stonith-enabled=on \ stonith-action=reboot \ no-quorum-policy=stop \ cluster-name=bionic * After that you can remove the interconnect of one of the nodes and watch the cluster to shutdown the node that was disconnected from the cluster ring. [Regression Potential] * Bionic wise: - Same as focal, but here it is even better situation as there isn't an existing fence_aws agent. Biggest problem here could be introduce something that does not fully work (which is technically not a regression). [Other Info] - This is a request from AWS to backport existing fence_aws agent into Bionic: - @redhat.com> - Date: Thu Mar 5 13:10:29 2020 + This is a request from AWS to backport existing fence_aws agent into + Bionic - fence_aws: improve connect parameter logic, so region can be specified - as parameter, while using role or keys from ~/.aws/config - - commit 7ac16fb2 - Author: Oyvind Albrigtsen <oalbr...@redhat.com> - Date: Fri Jan 31 14:53:47 2020 - - fence_aws: improve logging and metadata/usage text - - commit a3f45322 - Author: Oyvind Albrigtsen <oalbr...@redhat.com> - Date: Tue Mar 7 10:04:49 2017 - - fence_aws: new agent - ---- Currently fence-agents Ubuntu Bionic version is at: 4.0.25-2ubuntu1 and the fence_aws new agent started at: $ git tag --contains a3f45322 | head -1 v4.1.0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894323 Title: Add fence_aws fencing from v4.6.0 agent to Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fence-agents/+bug/1894323/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
