The attached debdiff fixes the dkms package build issues with linux-5.8. ** Description changed:
+ [Impact] + The xtables-addons DKMS package FTBFS with the new linux-hwe-5.8 kernel on Focal. + + [Test case] + Install and load the modules with Focal linux-generic (5.4) and linux-hwe-5.8. + + [Regression potential] + The same modifications have been done on Groovy (xtables-addons_3.9-1) to make it compatible with the procfs changes made on linux 5.6 (commit d56c0d45f0e2 proc: decouple proc from VFS with "struct proc_ops"). In theory these modifications would not affect functionality, but some issues could appear if these changes were not done properly to adapt to the new procfs interface. The same issues would happen on Groovy as well though. + + --- dkms package failed to build on: amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/x/xtables-addons/20201016_103232_0ab3a@/log.gz arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/x/xtables-addons/20201016_142034_04b8d@/log.gz armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/armhf/x/xtables-addons/20201016_110303_4b798@/log.gz ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/x/xtables-addons/20201016_110838_2ccbd@/log.gz s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/x/xtables-addons/20201016_081838_aa80b@/log.gz Build error: /var/lib/dkms/xtables-addons/3.8/build/extensions/pknock/xt_pknock.c: In function ‘add_rule’: /var/lib/dkms/xtables-addons/3.8/build/extensions/pknock/xt_pknock.c:472:22: error: passing argument 4 of ‘proc_create_data’ from incompatible pointer type [-Werror=incompatible-pointer-types] - 472 | &pknock_proc_ops, rule); - | ^~~~~~~~~~~~~~~~ - | | - | const struct file_operations * + 472 | &pknock_proc_ops, rule); + | ^~~~~~~~~~~~~~~~ + | | + | const struct file_operations * In file included from /var/lib/dkms/xtables-addons/3.8/build/extensions/pknock/xt_pknock.c:18: ./include/linux/proc_fs.h:102:31: note: expected ‘const struct proc_ops *’ but argument is of type ‘const struct file_operations *’ - 102 | extern struct proc_dir_entry *proc_create_data(const char *, umode_t, - | ^~~~~~~~~~~~~~~~ + 102 | extern struct proc_dir_entry *proc_create_data(const char *, umode_t, + | ^~~~~~~~~~~~~~~~ ** Patch added: "xtables-addons_3.8-2ubuntu1.debdiff" https://bugs.launchpad.net/ubuntu/+source/xtables-addons/+bug/1901560/+attachment/5427771/+files/xtables-addons_3.8-2ubuntu1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1901560 Title: xtables-addons 3.8-2 fails to build on Focal with linux-hwe-5.8 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xtables-addons/+bug/1901560/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
