> + len = buff_len < 8 ? -ENODATA : > + (buff_len <= maxlen ? buff_len : maxlen); > + memcpy (str, buff, len);
This looked concerning to me. There's a code path that will call memcpy with a len of -ENODATA which seemed quite dangerous to me. Upstream seems to have already fixed this here: https://git.opensvc.com/gitweb.cgi?p=multipath- tools/.git;a=blob;f=libmultipath/discovery.c;h=193d7127addbd3ad3feec30d1f67e20dabfb1293;hb=HEAD#l1303 Could you incorporate this please? Are there any other changes made upstream to this code since the cherry-picks which are also relevant? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1891202 Title: Multipathd hangs with long iscsi target names in Ubuntu 18.04 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/1891202/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
