Matthew, thanks for the great work in this bug and patches. Uploaded to Groovy and Focal w/ trivial changes; attached.
cheers, Mauricio ... debdiffs: I've modified the patch files slightly, as we discussed; - keep the commit messages; - use its/patch headers for DEP3, adding Origin: / Bug-Ubuntu: - added prefix keywords upstream/backport to Origin;, and documented changes done to backport patches 2,3. upstream: - no additional changes upstream that further change/fix these patches. downstream: - changelog looks good. - version numbers and upgrade path look good. - no other current uploads/versions in -proposed - no block-proposed[-<release>] tag build: The packages built successfully on all architectures on a PPA with -proposed enabled (as on build environments.) tests: I've done testing with your steps (thanks!) and the new test introduced in patch 2, manually. Unfortunately it doesn't run at build time as the package --disable-valgrind in debian/rules. > PASS: basic-sessionbreak-vg.sh # --enable-valgrind in d/rules; install valgrind/libtool; chmod +x And also we don't have autopkgtests on librelp [1] nor rsyslog [2] (single reverse dep for librelp0). So the two tests above seem to be really the only tests for this. All good as both have positive results! ... $ grep Package: debian/control Package: librelp0 Package: librelp-dev $ apt rdepends librelp0 librelp0 Reverse Depends: Depends: librelp-dev (= 1.5.0-1ubuntu2) Depends: rsyslog-relp (>= 1.5.0) Depends: rsyslog-relp (>= 1.4.0) ubuntu@librelp-f:~/librelp-1.5.0$ apt rdepends librelp-dev librelp-dev Reverse Depends: $ apt-cache show rsyslog-relp | grep Source: Source: rsyslog Source: rsyslog [1] https://autopkgtest.ubuntu.com/packages/librelp [1] https://autopkgtest.ubuntu.com/packages/rsyslog -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1908473 Title: rsyslog-relp: imrelp module leaves sockets in CLOSE_WAIT state which leads to file descriptor leak To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librelp/+bug/1908473/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
