The code in this change looks OK, but it's also a lot of change to propose backporting to a stable release. Unfortunately, Luminous is EoL upstream or we could push to land it upstream and bring it in via an upstream point release which would be a bit safer for us.
Because this is fairly large of a change, I'd like to see a more comprehensive test case for the SRU to ensure that we aren't regressing other things by removing the blkid calls. As called out in the regression potential, things that read the output of ceph-volume may be impacted, so I'd like to see that covered as well in the test case. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1908375 Title: ceph-volume lvm list <device> calls blkid numerous times for differrent devices To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
