** Description changed:
- The upstream linux-stable release v4.14.217 contains the following
- commit (also attached here):
+ [Impact]
+ wireguard-dkms won't build on bionic 4.15 kernels with upstream commit
5440233ac430 ("net: use skb_list_del_init() to remove from RX sublists")
applied.
+
+ [Fix]
+ Detect whether skb_mark_not_on_list is present in kernel headers by creating
a config.h file and using it to either define or not the same function on
compat.h.
+
+ [Test case]
+ Build the dkms module against a 4.15 and 5.4 kernel, as the 5.4 kernel has
the commit.
+
+ [Regression potential]
+ wireguard-dkms could stop building for some kernel versions.
+
+
+ ----------------------------------------------------------------
+
+
+ The upstream linux-stable release v4.14.217 contains the following commit
(also attached here):
5440233ac430 net: use skb_list_del_init() to remove from RX sublists
... which introduces skb_mark_not_on_list() to linux v4.14. This will
cause a wireguard-linux-compat build failure for v4.14-based kernels, as
well as Ubuntu Bionic (v4.15) which takes ports of the 4.14-series patch
sets:
- <<DKMSDIR>>/build/wireguard/1.0.20201112/build/compat/compat.h:830:20:
error:
- redefinition of 'skb_mark_not_on_list'
- static inline void skb_mark_not_on_list(struct sk_buff *skb)
- In file included from
<<DKMSDIR>>/build/wireguard/1.0.20201112/build/compat/compat.h:789:0,
- ./include/linux/skbuff.h:1346:20: note: previous definition of
'skb_mark_not_on_list' was here
- static inline void skb_mark_not_on_list(struct sk_buff *skb)
+ <<DKMSDIR>>/build/wireguard/1.0.20201112/build/compat/compat.h:830:20:
error:
+ redefinition of 'skb_mark_not_on_list'
+ static inline void skb_mark_not_on_list(struct sk_buff *skb)
+ In file included from
<<DKMSDIR>>/build/wireguard/1.0.20201112/build/compat/compat.h:789:0,
+ ./include/linux/skbuff.h:1346:20: note: previous definition of
'skb_mark_not_on_list' was here
+ static inline void skb_mark_not_on_list(struct sk_buff *skb)
For Bionic, the situation is complicated since Bionic's v4.15
KERNEL_VERSION 'SUBLEVEL' does not encode the SUBLEVEL number (217) from
the 4.14 series, so a simple switch on SUBLEVEL will not be sufficient
for Bionic.
We're holding out the port of the noted stable commit from Bionic,
pending resolution of this.
** Patch added: "adds LP bug number to changelog"
https://bugs.launchpad.net/ubuntu/+source/wireguard-linux-compat/+bug/1915304/+attachment/5462698/+files/wireguard-linux-compat_1.0.20201112-1~18.04.2.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1915304
Title:
linux-stable v4.14.217 causes skb_mark_not_on_list() build failure
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wireguard-linux-compat/+bug/1915304/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
