Thanks for the review Sergio! I am going to fix my email address in the groovy package and upload all of them. Also fix/improve the bug description.
** Description changed: [Impact] Due to our current policy we keep updating the container stack in all supported releases with new upstream versions. runc is part of this stack, and currently versions of opengcs in Bionic, Focal and Groovy do not support runc / 1.0.0 ~ rc93-0ubuntu1. opengcs tries to make use of system.GetClockTicks which would require a dependency on cgo. runc upstream decided to stop using it here: https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817 In Hirsute, a similar approach was implemented in opengcs to allow runc migration. Now, in order to unblock the runc SRUs we need to backport the Hirsute patch. [Test Plan] - The upstream test suite seems to be enough to caught any potential issue + The upstream test suite seems to be enough to catch any potential issue in this case. [Where problems could occur] - We are replacing a system call which would require cgo with a constant. - According to this comment this is safe enough: + We are replacing a system call which would require cgo with a known + constant to avoid this dependency. This approach was adopted by runc + upstream maintainers, and according to this comment this is safe enough: https://github.com/containerd/cgroups/pull/12#issuecomment-311322400 But the scenario where someone compile its own kernel and change the value of this constant will be inconsistent. However, this is not a big deal IMO, someone changing its own kernel needs to handle the consequences. [Original Message] opencgs test is failing and blocking runc/1.0.0~rc92-0ubuntu1 from migrating to hirsute: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac /autopkgtest- hirsute/hirsute/amd64/o/opengcs/20210118_162901_84e57@/log.gz This is the important bits: # vendor/github.com/docker/containerd/sys src/vendor/github.com/docker/containerd/sys/proc.go:17:34: undefined: system.GetClockTicks The new runc version does not provide GetClockTicks anymore: https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817 We should do the same in opengcs. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
