> 1) According to Lucas, this should not be a problem because we are backporting a version from Hirsute, which already contains the postinst excerpt you're referring to (the ZFS one, if I'm understanding correctly). The extra hunk that is being added to the posting script is just related to ZFS, and it has been tested on Hirsute (as mentioned) and backported to Groovy already, and it's making its way down the line. Not sure if this answers the question; let me know if you need more details.
My concern is that the postinst needs for Bionic and Focal may be different to the postinst needs for Hirsute, so it isn't sufficient to consider this change safe just because it works on Hirsute. For example, users will run the Bionic postinst when upgrading from Xenial, whereas this isn't a use case that the Hirsute (or sid) docker.io.postinst needs to support. Same for the upgrade path from the Bionic release pocket to this Bionic upload, for example. If you think these types of use cases will all work correctly then that's fine, but maybe worth testing the various postinst paths when verifying this SRU by adding to the Test Plan? > 2) Indeed, we need a trasitional package for this one. I am working on it, and will ping someone an AA before proceeding with the upload. I have already left a message on #ubuntu-release to the archive admins asking for a pre-approval before I go ahead and upload. Is it worth attempting the rename at all in this SRU? What if you provided the new name as a virtual package instead of renaming, for example (I've not thought through how this would work with future upgrades though)? In any case I think whatever an AA approves is fine. > 3) The change is intentional and comes from upstream. Great - +1! I'm holding on docker.io/containerd/golang-github-containers- buildah/opengcs until you're happy with point 1, and an AA agrees a plan for point 2 and we're ready with an appropriate upload for that. Apart from that, everything else is ready from an SRU review perspective. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919322 Title: Backport the container stack in Hirsute To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/containerd/+bug/1919322/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
