** Description changed: [impact] the 'configure' file checks for the existence of a '.git' directory, and if present it enables special build options that aren't used for 'normal' builds, some of which may cause the build to fail. This doesn't affect builds in PPAs or in the archive, since those do not happen in a git repo checkout, but this does cause very confusing failures and/or alternate behavior when building locally from a 'git ubuntu' checkout of the package. [test case] pull-lp-source qemu and build; assuming the build-deps are installed, it will build correctly. git ubuntu clone qemu and build; it will likely fail to build even if build-deps are installed, and even if it does build, the result will be different than a non-git build. [regression potential] - any regression would likely cause a failed build, or incorrectly built - package. + A regression would likely cause a failed build, or incorrectly built + package. We need to differ here for "packaging build" and "local + (manual) build". For the "local (manual) build" the regression is net to + zero as it currently does not work (or only with many many hurdles). The + "packaging build" is the more interesting one for this category. Here + the change should essentially turn out as no-op, but in case the most + likely regression is that this turns out to "change" the build result in + unexpected ways. [scope] this 'feature' comes from upstream, so this is needed in all releases. [other info] submitted patch upstream: https://lists.nongnu.org/archive/html/qemu-trivial/2020-07/msg00180.html and to Debian: https://salsa.debian.org/qemu-team/qemu/-/merge_requests/14 this is related to bug 1887823, since building for bionic from a git repo fails due to that bug also.
** Description changed: [impact] the 'configure' file checks for the existence of a '.git' directory, and if present it enables special build options that aren't used for 'normal' builds, some of which may cause the build to fail. This doesn't affect builds in PPAs or in the archive, since those do not happen in a git repo checkout, but this does cause very confusing failures and/or alternate behavior when building locally from a 'git ubuntu' checkout of the package. [test case] pull-lp-source qemu and build; assuming the build-deps are installed, it will build correctly. git ubuntu clone qemu and build; it will likely fail to build even if build-deps are installed, and even if it does build, the result will be different than a non-git build. - [regression potential] + [Where problems could occur] A regression would likely cause a failed build, or incorrectly built package. We need to differ here for "packaging build" and "local (manual) build". For the "local (manual) build" the regression is net to zero as it currently does not work (or only with many many hurdles). The "packaging build" is the more interesting one for this category. Here the change should essentially turn out as no-op, but in case the most likely regression is that this turns out to "change" the build result in unexpected ways. [scope] this 'feature' comes from upstream, so this is needed in all releases. [other info] submitted patch upstream: https://lists.nongnu.org/archive/html/qemu-trivial/2020-07/msg00180.html and to Debian: https://salsa.debian.org/qemu-team/qemu/-/merge_requests/14 this is related to bug 1887823, since building for bionic from a git repo fails due to that bug also. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887535 Title: build operates differently if source is a git repo To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1887535/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
